-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: BROS-509: BROS-752: Improve ReactCode appearance in region list and Task Summary #9239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Objects rendered in a nice nested way to see all items. Empty arrays and objects are explicitly labeled as empty. Empty strings are rendered with quotes.
Show preselected values of ReactCode region in Region List.
Get all fields from ReactCode's `output` and display column for each of them in Task Summary view of View All.
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/git merge
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9239 +/- ##
===========================================
- Coverage 65.54% 56.14% -9.40%
===========================================
Files 847 574 -273
Lines 65896 41546 -24350
Branches 11484 11518 +34
===========================================
- Hits 43193 23327 -19866
+ Misses 22699 18215 -4484
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/fmt |
|
/git merge
|
|
/git merge
|
| .replace(/\[\*\]/g, "") // Remove array wildcards | ||
| .split(".") | ||
| .filter(Boolean) | ||
| .map((part) => part.charAt(0).toUpperCase() + part.slice(1)) // Capitalize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe we have lodash installed. you must be able to do _.capitalize(string) instead of a custom imlementation
Display chips for items with optional count if there are enums.
Its `value` is the code, so it's wrong to use it. Correct check is for `loadedData`
Make everything the same size
|
/git merge
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good - would be great to have pictures or a video of the changes to make it easier to understand the outcome. also I see some check failures but im sure atleast one of them is a flakey test
One column gets 100%, three 33% each. a lot of columns get 300px each.
No description provided.