Skip to content

fix: BROS-5: Last fixes for Interactive View All #7527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

Gondragos
Copy link
Collaborator

@Gondragos Gondragos commented May 14, 2025


Reason for change

  • Fixed tools initialization to prevent multiple initializations which led to the loss of default tool functionality.
  • Added a unique identifier to the Collapse model to support an interactive "View All" feature without breaking the application.
  • Remove last (?) occurencies of reaching to annotationStore.selected from tags
  • Quick fix TimeSeries async init to not crash the app when original instance is missing
  • Fixed lost cursor managing
  • Fixed Image's labels tools (didn't work like a tool)

Gondragos added 2 commits May 14, 2025 06:40
This prevents initializing tools multiple times which caused loosing
default tool functionality.
It allows to use it in interactive View All without breaking application
Copy link

netlify bot commented May 14, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit bac55de
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68272536ad2c4100088f392f

Copy link

netlify bot commented May 14, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit bac55de
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68272536328dbf0008a14144

Copy link

netlify bot commented May 14, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit bac55de
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68272536d5a340000873d5fa
😎 Deploy Preview https://deploy-preview-7527--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hlomzik hlomzik requested a review from a team as a code owner May 14, 2025 15:48
@hlomzik hlomzik changed the title Fb bros 5/iva fixes fix: BROS-5: Last fixes for Interactive View All May 14, 2025
Gondragos and others added 8 commits May 15, 2025 08:58
That was unselection of other connected labels and it was fixed
in HumanSignal/label-studio-frontend#1126
But the code was left in place.
Removing to avoid further confusion.
Collapse.Panel renders content lazily leading to permanent `isReady=false`
for object tags inside, hanging old View All.
Interactive View All renders tags usually and don't need any fixes.
It's actually failing in Interactive View All in a different way.
So we'll fix this separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants