feat: Points experiment #7454
Open
feat: Points experiment #7454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for label-studio-storybook failed. Why did it fail? →
|
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hlomzik
reviewed
May 1, 2025
|
|
||
| - Prefer `FC<Props>` or explicit function annotations. | ||
| - Never use `any`; fallback to `unknown` + type guards. | ||
| - Use union types instead of enums when possible. |
hlomzik
reviewed
May 1, 2025
.cursor/rules/react.mdc
Outdated
| - Always run `make fmt-all` (Prettier/Biome/Ruff) before committing. | ||
| - Use spaces around binary operators and after commas: `const xs = pts.map(p => p.data.x);` not `pts.map(p=>p.data.x)`. | ||
| - Limit line length to 100 chars; break long expressions. |
hlomzik
reviewed
May 1, 2025
.cursor/rules/react.mdc
Outdated
| ## Declarative Rendering vs Imperative Canvas | ||
|
|
||
| - Prefer **declarative SVG** (or a React-first charting lib such as `@visx/xy-chart`, `recharts`, `nivo`) for 2-D data‐viz inside React. |
There was a problem hiding this comment.
That's very specific and should be used for exact tasks. Adding it here will force agent to add new libds instead of reusing Konva.js or d3.js that we already have in our codebase
… points. Semi-Working version
… in tab_selected_items.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.