Skip to content

fix: DIA-1435: [FE, cust-Comet] Some errors on Prompt task list are not displayed gracefully on UI #7444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

nick-skriabin
Copy link
Member

This pull request makes a small enhancement to the tooltip styling by limiting its maximum width.

Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 56a7055
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-storybook/deploys/6824b2fb048ae70008d7706f
😎 Deploy Preview https://deploy-preview-7444--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the fix label Apr 30, 2025
Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 56a7055
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6824b2fbbbd3f800085a3731

Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 56a7055
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6824b2fb574bf10008bd480f

@nass600
Copy link
Contributor

nass600 commented May 1, 2025

@nick-skriabin @ricardoantoniocm Do we foresee any special case where we would like to override this max-width?

If we do I would recommend adding the tailwind class and allow merging from the outside with twMerge otherwise looks good

@ricardoantoniocm
Copy link
Contributor

@nick-skriabin @ricardoantoniocm Do we foresee any special case where we would like to override this max-width?

If we do I would recommend adding the tailwind class and allow merging from the outside with twMerge otherwise looks good

Thanks for raising this, Nacho.

Yes, I foresee that. Let's not set a max width in stone by ensuring it can be overwritten if necessary. Also, this particular change could affect how specific tooltips display info across the app. Let's make sure this change doesn't negatively affect the contents of tooltips across the app.

@nick-skriabin
Copy link
Member Author

@ricardoantoniocm @nass600 the width is customizable via style or className properties, so i don't see the problem here

@MihajloHoma
Copy link
Contributor

MihajloHoma commented May 5, 2025

/fm sync

Workflow run

@MihajloHoma
Copy link
Contributor

MihajloHoma commented May 6, 2025

/fm sync

Workflow run

@AndrejOros
Copy link
Contributor

AndrejOros commented May 7, 2025

/fm sync

Workflow run

@nick-skriabin nick-skriabin enabled auto-merge (squash) May 14, 2025 15:04
@nick-skriabin nick-skriabin disabled auto-merge May 14, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants