Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Fix Windows build on Node 14 #460

Merged
merged 6 commits into from
Jun 16, 2020
Merged

Fix Windows build on Node 14 #460

merged 6 commits into from
Jun 16, 2020

Conversation

matteovivona
Copy link
Contributor

@matteovivona matteovivona commented Jun 11, 2020

Link hospitalrun/#363

@matteovivona matteovivona added bug Something isn't working in progress labels Jun 11, 2020
@github-actions
Copy link

github-actions bot commented Jun 11, 2020

Size Change: 0 B

Total Size: 34.9 kB

ℹ️ View Unchanged
Filename Size Change
dist/components.cjs.development.js 13 kB 0 B
dist/components.cjs.production.min.js 8.92 kB 0 B
dist/components.esm.js 12.8 kB 0 B
dist/index.js 145 B 0 B

compressed-size-action

@fox1t fox1t merged commit e56d9fd into master Jun 16, 2020
@fox1t fox1t deleted the node14-windows branch June 16, 2020 14:37
@reidmeyer
Copy link

node 14 still has the same problem on the monorepo yarn build. Is this because we are switching to npm rather than yarn?

@matteovivona
Copy link
Contributor Author

currently, monorepo doesn't build for other issues. we're thinking of using another monorepo manager.

@fox1t
Copy link
Member

fox1t commented Jun 16, 2020

hi @reidmeyer I am still working on the monorepo. :)

@ghost
Copy link

ghost commented Jun 18, 2020

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working in progress released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants