Conversation
|
@Bo98 Everything looks good here except for the expected error on El Capitan. |
Signed-off-by: Patrick Linnane <patrick@linnane.io>
21b77ff to
5106526
Compare
@p-linnane @Bo98 what's expected about the error here? Missing context. |
|
Per Bo on the previous PR:
I have no other info than that. |
|
It's a usage of |
|
Would it not make more sense to drop El Capitan support if this a recurring issue? |
Signed-off-by: Patrick Linnane <patrick@linnane.io>
|
Yeah lost track of this with all the AGM stuff. Patch would be fairly trivial but 10.11 was on track for being dropped if we end up using We can drop 10.11 but I'll need to update the CI images to 10.12 which could be done on the 11th March maintenance window. And then coordinate Homebrew 4.5.0 to happen with that and the Ruby 3.4 minimum version bump. It's more work than patching but probably was going to happen eventually anyway. |
|
Let's just patch for now since it's trivial. Better than rushing with everything else that needs to happen. |
|
@Bo98 I'd also consider patching to be better her but if the CI images are changing anyway: feel free to do that instead. Would like to have this merged before end of March if at all possible. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Do we still want to patch this? |
|
Yes, sorry. The Orka upgrade took priority. If you don't hear from me by the next week feel free to do whatever here. The "before end of March" comment from above still applies. |
|
Definitely did not mean to insinuate this got dropped, so I'm sorry if it came off that way. I know how crazy the Orka upgrade was. I just wanted to throw a comment on here to ward off stalebot and bring this back to top of mind. Let me know if there's any way I can help with this. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Handling in #306. While not necessarily intentional, the delay here probably actually worked out for the best given RuboCop only got full 3.4 support a couple weeks ago. The idea of ignoring Ruby |
Created by
brew bumpCreated with
brew bump-formula-pr.resourceblocks have been checked for updates.