Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

portable-ruby 3.4.2#285

Closed
BrewTestBot wants to merge 3 commits intomasterfrom
bump-portable-ruby-3.4.2
Closed

portable-ruby 3.4.2#285
BrewTestBot wants to merge 3 commits intomasterfrom
bump-portable-ruby-3.4.2

Conversation

@BrewTestBot
Copy link
Copy Markdown
Contributor

@BrewTestBot BrewTestBot commented Feb 15, 2025

Created by brew bump


Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@p-linnane
Copy link
Copy Markdown
Member

@Bo98 Everything looks good here except for the expected error on El Capitan.

BrewTestBot and others added 2 commits February 25, 2025 10:27
Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane p-linnane force-pushed the bump-portable-ruby-3.4.2 branch from 21b77ff to 5106526 Compare February 25, 2025 18:28
@MikeMcQuaid
Copy link
Copy Markdown
Member

@Bo98 Everything looks good here except for the expected error on El Capitan.

@p-linnane @Bo98 what's expected about the error here? Missing context.

@p-linnane
Copy link
Copy Markdown
Member

Per Bo on the previous PR:

This has however been useful in revealing a bug on older macOS so will look into upstreaming a fix for that.

I have no other info than that.

@EricFromCanada
Copy link
Copy Markdown
Member

It's a usage of clock_gettime which, as we all remember, was only implemented in macOS 10.12. It's been patched before, but doesn't look like a PR has been issued so far.

@p-linnane
Copy link
Copy Markdown
Member

Would it not make more sense to drop El Capitan support if this a recurring issue?

Signed-off-by: Patrick Linnane <patrick@linnane.io>
@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Feb 26, 2025

Yeah lost track of this with all the AGM stuff.

Patch would be fairly trivial but 10.11 was on track for being dropped if we end up using copyfile (not in Ruby 3.4 though, maybe 3.5).

We can drop 10.11 but I'll need to update the CI images to 10.12 which could be done on the 11th March maintenance window. And then coordinate Homebrew 4.5.0 to happen with that and the Ruby 3.4 minimum version bump. It's more work than patching but probably was going to happen eventually anyway.

@p-linnane
Copy link
Copy Markdown
Member

Let's just patch for now since it's trivial. Better than rushing with everything else that needs to happen.

@MikeMcQuaid
Copy link
Copy Markdown
Member

@Bo98 I'd also consider patching to be better her but if the CI images are changing anyway: feel free to do that instead. Would like to have this merged before end of March if at all possible.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Mar 20, 2025
@p-linnane p-linnane removed the stale label Mar 20, 2025
@p-linnane
Copy link
Copy Markdown
Member

Do we still want to patch this?

@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Mar 20, 2025

Yes, sorry. The Orka upgrade took priority. If you don't hear from me by the next week feel free to do whatever here. The "before end of March" comment from above still applies.

@p-linnane
Copy link
Copy Markdown
Member

Definitely did not mean to insinuate this got dropped, so I'm sorry if it came off that way. I know how crazy the Orka upgrade was. I just wanted to throw a comment on here to ward off stalebot and bring this back to top of mind. Let me know if there's any way I can help with this.

@p-linnane p-linnane mentioned this pull request Apr 9, 2025
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Apr 12, 2025
@Bo98 Bo98 added in progress and removed stale labels Apr 12, 2025
@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Apr 15, 2025

Handling in #306.

While not necessarily intentional, the delay here probably actually worked out for the best given RuboCop only got full 3.4 support a couple weeks ago. The idea of ignoring Ruby X.Y.0 releases was to make sure all dependencies were updated and any regressions were addressed - and that process seems to have taken longer than usual this time round on the dependencies side.

@Bo98 Bo98 closed this Apr 15, 2025
@Bo98 Bo98 removed the in progress label Apr 15, 2025
@Bo98 Bo98 deleted the bump-portable-ruby-3.4.2 branch April 15, 2025 03:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants