Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/build: use new 11-arm64-cross runner #184

Merged
merged 1 commit into from
Mar 1, 2024
Merged

workflows/build: use new 11-arm64-cross runner #184

merged 1 commit into from
Mar 1, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Feb 28, 2024

This sees the final retirement of the non-ephemeral macOS CI.

I've also got a completely recreated 10.11-cross image that is picked up automatically here without any workflow changes but is being tested for the first time with the CI runs in this PR.

@Bo98
Copy link
Member Author

Bo98 commented Feb 28, 2024

Will do some tests in 10.11 VM before merging but I don't anticipate any issues

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, nice work here @Bo98!

@Bo98
Copy link
Member Author

Bo98 commented Mar 1, 2024

10.11 WindowServer under QEMU keeps crashing for me so will test it fully later before I make a release (Eric has a working setup).

I think I accidentally used CLT 14.2 (which claims 10.13 support) when I intended to use 13.4 (claims 10.9 support), but I'll either adjust that or just ignore it given the linker has inserted 10.11 minimum into the binary fine so must surely work ok.

@Bo98 Bo98 merged commit abb2a57 into master Mar 1, 2024
5 checks passed
@Bo98 Bo98 deleted the new-cross branch March 1, 2024 01:13
@EricFromCanada
Copy link
Member

No issues building and testing HEAD in 10.11 for me.

@Bo98
Copy link
Member Author

Bo98 commented Mar 2, 2024

Thanks. Did/can you test the binary from CI too? https://github.com/Homebrew/homebrew-portable-ruby/actions/runs/8088378084

@EricFromCanada
Copy link
Member

Ran brew reinstall -v --force-bottle portable-ruby--3.1.4.el_capitan.bottle.tar.gz and then brew test portable-ruby. Hopefully that covers it.

@Bo98
Copy link
Member Author

Bo98 commented Mar 3, 2024

Should do yeah. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants