Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Sorbet typechecking #538

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Enable Sorbet typechecking #538

wants to merge 2 commits into from

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Dec 24, 2024 •
edited
Loading

@issyl0 issyl0 mentioned this pull request Dec 24, 2024
Closed
7 tasks
@issyl0
If we rewrite the PyCall module import, does it work?
9780d54 
- Sorbet complained about the original `Module.new(...)` syntax.
- So I rewrote it to make a `module InfluxDBClient3` and then
  `include` it.
- But then the actual formula-analytics command stopped
  working because it couldn't find the reference to
  `InfluxDBClient3.new`.
- If we take a different approach here, is that any better?
SMillerDev
SMillerDev approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know much about how the pycall part works, but I'm stoked that there's sorbet in taps now.

MikeMcQuaid
MikeMcQuaid approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge, thanks!

@MikeMcQuaid MikeMcQuaid requested a review from Bo98 December 30, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@Bo98 Bo98 Awaiting requested review from Bo98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@issyl0 @MikeMcQuaid @SMillerDev