Skip to content

tinymist 0.14.14#274667

Open
GunniBusch wants to merge 1 commit intoHomebrew:mainfrom
GunniBusch:bump-tinymist-0.14.14
Open

tinymist 0.14.14#274667
GunniBusch wants to merge 1 commit intoHomebrew:mainfrom
GunniBusch:bump-tinymist-0.14.14

Conversation

@GunniBusch
Copy link
Copy Markdown
Contributor

@GunniBusch GunniBusch commented Mar 27, 2026


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

fixes #274592.

failed because the previous test expected an LSP initialize response on stdout, but tinymist 0.14.14 did not emit the expected Content-Length header in CI.

This keeps tinymist probe and replaces the timing-sensitive LSP exchange with a compile test that writes a minimal Typst document and checks that a PDF is produced.

@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Mar 27, 2026
Copy link
Copy Markdown
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain your changes when opening these kinds of PRs.
Substantial changes to tests should be described adequately.

Was there a significant refactor of the package that requires test refactoring?
Are we removing tests that uncovered genuine regressions?

@daeho-ro daeho-ro marked this pull request as draft March 28, 2026 17:25
@GunniBusch
Copy link
Copy Markdown
Contributor Author

Please explain your changes when opening these kinds of PRs. Substantial changes to tests should be described adequately.

Was there a significant refactor of the package that requires test refactoring? Are we removing tests that uncovered genuine regressions?

Sorry, have missed this (also missed putting this in draft), as I fall asleep yesterday. I was just testing out how to make the test more robust but still show failures to indicate upstream changes. This means, testing lsp function might not be that stable since it might have too much false positive failes.

Will, update it

@GunniBusch GunniBusch force-pushed the bump-tinymist-0.14.14 branch from 99e49b7 to 85db117 Compare March 29, 2026 02:28
@GunniBusch GunniBusch requested a review from bevanjkay March 29, 2026 02:29
@GunniBusch GunniBusch marked this pull request as ready for review March 29, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants