Conversation
bevanjkay
left a comment
There was a problem hiding this comment.
Please explain your changes when opening these kinds of PRs.
Substantial changes to tests should be described adequately.
Was there a significant refactor of the package that requires test refactoring?
Are we removing tests that uncovered genuine regressions?
Sorry, have missed this (also missed putting this in draft), as I fall asleep yesterday. I was just testing out how to make the test more robust but still show failures to indicate upstream changes. This means, testing lsp function might not be that stable since it might have too much false positive failes. Will, update it |
99e49b7 to
85db117
Compare
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?fixes #274592.
failed because the previous test expected an LSP
initializeresponse on stdout, buttinymist 0.14.14did not emit the expectedContent-Lengthheader in CI.This keeps
tinymist probeand replaces the timing-sensitive LSP exchange with a compile test that writes a minimal Typst document and checks that a PDF is produced.