Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various: add resource livecheck referencing parent #204587

Merged
merged 31 commits into from
Jan 17, 2025

Conversation

nandahkrishna
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This PR adds livecheck blocks to resources whose versions must match those of the parent formula. I have added these blocks even in cases where livecheck guesses the right version for the following reasons:

  • It will reduce the number of network requests since the formula's latest version is directly used.
  • We do not care for any other versions since these resources must match the parent formula version.
  • In a forthcoming Homebrew/brew PR, I will add the ability for bump-formula-pr and bump to autobump these resources.

@nandahkrishna nandahkrishna added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Jan 17, 2025
@nandahkrishna nandahkrishna requested a review from samford January 17, 2025 09:15
@github-actions github-actions bot added CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing labels Jan 17, 2025
@nandahkrishna nandahkrishna removed CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing labels Jan 17, 2025
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nanda!

@samford samford added this pull request to the merge queue Jan 17, 2025
Merged via the queue into master with commit 2c976a1 Jan 17, 2025
22 checks passed
@samford samford deleted the parent-resource-livecheck branch January 17, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants