Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insect: deprecate in favor of numbat #202613

Merged
merged 1 commit into from
Dec 29, 2024
Merged

insect: deprecate in favor of numbat #202613

merged 1 commit into from
Dec 29, 2024
+4 −0

Conversation

dtrodrigues
Copy link
Member

Created with brew bump-formula-pr.

@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Dec 28, 2024
@bevanjkay
Copy link
Member

The upstream repository hasn't had a new release, and no commits for two months. But it may still be a genuine release.

bayandin
bayandin previously approved these changes Dec 28, 2024
View reviewed changes
@bayandin bayandin dismissed their stale review December 28, 2024 10:18

As per comment above

@bevanjkay
Copy link
Member

bevanjkay commented Dec 28, 2024 •
edited
Loading

It looks like the primary change made was to add a line to the readme pointing to the numbat project instead. Perhaps this should be deprecated while we are here.

@github-actions github-actions bot added the formula deprecated Formula deprecated label Dec 29, 2024
@chenrui333 chenrui333 changed the title insect 5.9.1 insect: deprecate in favor of numbat Dec 29, 2024
@chenrui333
Copy link
Member

yeah, deprecating makes sense to me 👍

@chenrui333 chenrui333 mentioned this pull request Dec 29, 2024
Open
@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Dec 29, 2024
@bevanjkay
Copy link
Member

Should we use the replacement parameter for deprecate here?

@chenrui333
Copy link
Member

good point 👍

@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 29, 2024
Merged via the queue into master with commit 716a1a4 Dec 29, 2024
17 checks passed
@BrewTestBot BrewTestBot deleted the bump-insect-5.9.1 branch December 29, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bevanjkay bevanjkay bevanjkay approved these changes

@bayandin bayandin Awaiting requested review from bayandin

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated nodejs Node or npm use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dtrodrigues @bevanjkay @chenrui333 @bayandin @BrewTestBot