Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sdk-cpp: add aws-crt-cpp dependency #199676

Merged
merged 6 commits into from
Jan 3, 2025
Merged

aws-sdk-cpp: add aws-crt-cpp dependency #199676

merged 6 commits into from
Jan 3, 2025

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 1, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m marked this pull request as draft December 1, 2024 20:32
@github-actions github-actions bot added the long build Set a long timeout for formula testing label Dec 1, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Dec 23, 2024
@github-actions github-actions bot removed the stale No recent activity label Dec 29, 2024
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux has undeclared linkage to s2n, but otherwise looks good to me. Thanks!

@cho-m
Copy link
Member Author

cho-m commented Dec 30, 2024

Linux has undeclared linkage to s2n

Looks like switch from GCC to Clang (due to Protobuf 29) has changed the default --as-needed.

May try manually passing it in to reduce linkage on Linux.

Formula/s/s2n.rb Show resolved Hide resolved
@cho-m cho-m force-pushed the aws-sdk-cpp-deps branch from f3a2b89 to e0781e4 Compare January 3, 2025 14:17
@cho-m cho-m marked this pull request as ready for review January 3, 2025 14:17
Copy link
Contributor

github-actions bot commented Jan 3, 2025

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 3, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 3, 2025 18:56
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 3, 2025
Merged via the queue into master with commit f711ae2 Jan 3, 2025
15 checks passed
@BrewTestBot BrewTestBot deleted the aws-sdk-cpp-deps branch January 3, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants