Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avro-c avro-cpp avro-tools 1.11.1 #118877

Closed

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Dec 24, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

continuing #107777
upstream patch, apache/avro#1826

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Dec 24, 2022
p-linnane
p-linnane previously approved these changes Dec 24, 2022
@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Dec 25, 2022
@SMillerDev
Copy link
Member

  -- Installing: /opt/homebrew/Cellar/avro-c/1.11.1/bin/avromod
  Error: An exception occurred within a child process:
    Errno::ENOENT: No such file or directory - tests/test_avro_1087

system "cmake", "-S", ".", "-B", "build", *std_cmake_args
system "cmake", "--build", "build"
system "cmake", "--install", "build"

pkgshare.install "tests/test_avro_1087"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: An exception occurred within a child process:
    Errno::ENOENT: No such file or directory - tests/test_avro_1087

Build may be skipping compiling test now. May want to just install a C test code and compile it during the test block.

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jan 28, 2023
@github-actions github-actions bot closed this Feb 4, 2023
@SMillerDev SMillerDev reopened this Feb 20, 2023
@SMillerDev SMillerDev force-pushed the avro-c-avro-cpp-avro-tools-1.11.1 branch 2 times, most recently from 3d8a572 to 800d9c5 Compare February 20, 2023 09:51
@SMillerDev
Copy link
Member

No idea how to fix this one.

  /opt/homebrew/include/avro/CustomFields.hh:24:10: fatal error: '../impl/json/JsonDom.hh' file not found
  #include "../impl/json/JsonDom.hh"
           ^~~~~~~~~~~~~~~~~~~~~~~~~

@github-actions github-actions bot removed the stale No recent activity label Feb 20, 2023
@SMillerDev SMillerDev force-pushed the avro-c-avro-cpp-avro-tools-1.11.1 branch from 800d9c5 to f769870 Compare February 20, 2023 10:55
@SMillerDev SMillerDev removed the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Feb 20, 2023
@SMillerDev SMillerDev force-pushed the avro-c-avro-cpp-avro-tools-1.11.1 branch 2 times, most recently from b080f6c to 2c598f7 Compare February 20, 2023 12:24
@SMillerDev
Copy link
Member

I'm dropping avro-cpp from this. It can be updated in the next release.

Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
@SMillerDev SMillerDev force-pushed the avro-c-avro-cpp-avro-tools-1.11.1 branch from 2c598f7 to a833f46 Compare February 22, 2023 12:41
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Mar 17, 2023
@github-actions github-actions bot closed this Mar 24, 2023
@chenrui333 chenrui333 deleted the avro-c-avro-cpp-avro-tools-1.11.1 branch January 22, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No recent activity test failure CI fails while running the test-do block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants