Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adobe-photoshop-lightroom: remove uninstall_preflight #40800

Closed
wants to merge 1 commit into from
Closed

Update adobe-photoshop-lightroom: remove uninstall_preflight #40800

wants to merge 1 commit into from

Conversation

commitay
Copy link
Contributor

@commitay commitay commented Nov 15, 2017

This is also break when Homebrew/brew#3396 is merged.

As this is a patch installer on top of another Cask it doesn't need an uninstall itself, the app can be removed by uninstalling lightroom600.

The patch upgrade can be applied on top of the previous patch.

@commitay
Copy link
Contributor Author

>>> brew cask _audit_modified_casks 5c0d832f7d5846170347cc6c573400160379ba5c...a4b7d4a84cd0833500349fcce205256e7f4857ff
==> 1 modified cask: adobe-photoshop-lightroom
audit for adobe-photoshop-lightroom: passed

>>> brew cask style Casks/adobe-photoshop-lightroom.rb
1 file inspected, no offenses detected

@commitay
Copy link
Contributor Author

Going to leave this as is for now. It won't actually "break" the upgrade, it will just install a clean version and then patch it.

@commitay commitay closed this Nov 28, 2017
@commitay commitay deleted the lightroom branch November 28, 2017 02:24
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant