This repository has been archived by the owner on May 16, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font installation has changed a few times (particularly from caskroom tap) and googling for how to install fonts via Brewfile surfaces a few conflicting approaches.
I think it would be beneficial if taps documented how they were to be used within a Brewfile. This is especially helpful for homebrew's first-party taps, to remove any potential confusion that there may perhaps be a
font "inconsolata"
mechanism or similar; given thatbrew
,cask
,mas
,whalebrew
andvscode
are all first-class Brewfile methods. It also eliminates any confusion about whether thefont-
prefix should be present in the Brewfile, given that there are other prefixes in the homebrew ecosystem that can conventionally be omitted in certain cases. Thus, an explicit example seems worthwhile.(not a cask PR, so the following is not applicable)
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.