Skip to content

Conversation

@p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We've decided to stop pushing to Docker Hub due to reliability issues. This PR also removes the 20.04 image in preparation for Homebrew 4.7.0.

Copilot AI review requested due to automatic review settings October 24, 2025 18:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Docker Hub as a publishing target for Homebrew's Docker images and drops support for Ubuntu 20.04 images in preparation for Homebrew 4.7.0 release. The changes streamline the Docker workflow by eliminating deprecated image variants and simplifying the publishing pipeline.

Key changes:

  • Removed Docker Hub authentication and all homebrew/* image tags
  • Eliminated Ubuntu 20.04 from the version matrix and removed related conditional logic
  • Cleaned up deprecation notices and special handling for 20.04 images
Comments suppressed due to low confidence (1)

.github/workflows/docker.yml:1

  • With the removal of the 20.04 version check, this line will now attempt to add an ARM64 digest for all versions. However, the code on line 278 initializes image_args as a single-element array. This line should unconditionally add the ARM64 digest since 20.04 (which had no ARM64 build) has been removed from the version matrix.
name: Docker

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

carlocab added a commit to Homebrew/homebrew-core that referenced this pull request Oct 25, 2025
We're no longer updating Docker Hub. See Homebrew/brew#20938.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Marking draft just so we don't merge before we're ready for 4.7 being next release.

@MikeMcQuaid MikeMcQuaid marked this pull request as draft October 25, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants