Add appimage support for linux #20334

SMillerDev · 2025-07-30T20:38:53Z

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew style with your changes locally?
Have you successfully run brew typecheck with your changes locally?
Have you successfully run brew tests with your changes locally?

This adds support for the first linux-only cask stanza: app_image.
We should probably add CI for Linux casks, but haven't been able to get that working yet.

MikeMcQuaid · 2025-07-31T09:06:34Z

We should probably add CI for Linux casks, but haven't been able to get that working yet.

Need CI before this PR is merged.

Where are the app images installed and is that an expected/sensible location?

Maybe we should reuse app for this on Linux (or is that too confusing)?

SMillerDev · 2025-07-31T09:29:37Z

Maybe we should reuse app for this on Linux

I considered it, but deemed it too confusing. Especially with it not working on macOS.

Where are the app images installed and is that an expected/sensible location?

In ~/Applications, their docs recommend it.
https://docs.appimage.org/user-guide/faq.html#question-where-do-i-store-my-appimages

MikeMcQuaid · 2025-07-31T11:02:23Z

@SMillerDev sounds good 👍🏻

SMillerDev · 2025-08-01T10:02:51Z

I'm also considering adding a desktop file for these so the various Linux systems can pick it up easily.

Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/

github-actions · 2025-08-23T00:16:38Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

SMillerDev · 2025-08-23T06:46:03Z

This is waiting for the following pieces:

Adding integration tests to testbot so I don't break it again
Add cask change detection to testbot
Adding Linux CI to homebrew/cask

github-actions · 2025-09-14T00:17:40Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

SMillerDev · 2025-09-14T08:43:30Z

Not stale, but it is waiting for Linux CI for casks, and that's not going as fast as I'd like. So help would be much appreciated.

SMillerDev · 2025-10-05T12:02:15Z

Okay, now that Linux CI for casks is merged I'm planning to:

make a PR that stops requiring --cask in Linux
Prepare this PR for review

Copilot

Pull Request Overview

This PR adds AppImage support as a Linux-only cask stanza, extending Homebrew's cross-platform capabilities. It implements a new artifact type app_image that allows Linux users to install AppImage applications through Homebrew casks.

Implements AppImage artifact class with symlink functionality
Updates OS-specific installer logic to validate platform compatibility
Enhances CI matrix generation to support Linux cask testing

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Library/Homebrew/cask/artifact/appimage.rb	New AppImage artifact class that extends symlinked artifacts
Library/Homebrew/cask/artifact.rb	Registers AppImage in artifact system and defines Linux-only artifacts
Library/Homebrew/cask/config.rb	Adds appimagedir configuration option with default path
Library/Homebrew/cli/parser.rb	Adds --appimagedir CLI flag for configuring AppImage installation directory
Library/Homebrew/cask/dsl.rb	Registers AppImage as an ordinary artifact class in DSL
Library/Homebrew/cask/cask.rb	Updates platform support detection logic for macOS and Linux
Library/Homebrew/extend/os/mac/cask/installer.rb	New macOS-specific installer validation
Library/Homebrew/extend/os/linux/cask/installer.rb	Updates Linux installer validation logic
Library/Homebrew/extend/os/cask/installer.rb	Includes macOS-specific installer extensions
Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb	Enhances CI matrix generation for Linux cask support

Comments suppressed due to low confidence (1)

Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb:1

Empty comment should either be removed or expanded to explain why the exception is being silently ignored, unlike the macOS case which logs the error message.

# typed: strict

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb

Library/Homebrew/cask/cask.rb

SMillerDev · 2025-10-21T15:14:37Z

I guess this is an implementation of #15808

MikeMcQuaid

Looks good so far.

MikeMcQuaid · 2025-10-22T14:22:33Z

Library/Homebrew/cask/cask.rb

+    def supports_macos?
+      return true if font?
+
+      if @dsl.on_system_blocks_exist?


Given this block is nearly identical in the macOS and Linux cases: it'd be nicer to have a shared helper method in this class that both cases call.

MikeMcQuaid · 2025-10-22T14:23:10Z

Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb

            # we don't need to run simulated archs on Linux
            next if runner.fetch(:symbol) == :linux && !native_runner_arch
-            # we don't need to run simulated archs on macOS
+            # we don't need to run simulated archs on macOS Sequoia


Because an intel runner exists for it, in contrary to all the other macOS versions

Suggested change

# we don't need to run simulated archs on macOS Sequoia

# we don't need to run simulated archs on macOS Sequoia

# because it has a GitHub hosted x86_64 runner

Should I add the same to the Linux block above?

if that's the reason: yup!

SMillerDev mentioned this pull request Jul 30, 2025

krita: add linux appimage support Homebrew/homebrew-cask#222068

Open

8 tasks

SMillerDev force-pushed the feat/cask/appimage branch from c91f2f7 to caba75a Compare July 30, 2025 20:40

github-actions bot added the stale No recent activity label Aug 23, 2025

github-actions bot removed the stale No recent activity label Aug 23, 2025

github-actions bot added the stale No recent activity label Sep 14, 2025

SMillerDev added help wanted We want help addressing this in progress Maintainers are working on this and removed stale No recent activity labels Sep 14, 2025

bevanjkay mentioned this pull request Sep 15, 2025

Add support for Linux to visual-studio-code cask Homebrew/homebrew-cask#228061

Closed

5 tasks

MikeMcQuaid removed help wanted We want help addressing this in progress Maintainers are working on this labels Oct 2, 2025

SMillerDev force-pushed the feat/cask/appimage branch from caba75a to 85b07ae Compare October 7, 2025 20:43

SMillerDev force-pushed the feat/cask/appimage branch from 85b07ae to 3f62e6a Compare October 18, 2025 17:58

SMillerDev marked this pull request as ready for review October 18, 2025 17:58

Copilot AI review requested due to automatic review settings October 18, 2025 17:58

SMillerDev force-pushed the feat/cask/appimage branch from 3f62e6a to 740bac5 Compare October 18, 2025 17:59

Copilot AI reviewed Oct 18, 2025

View reviewed changes

Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb Outdated Show resolved Hide resolved

Library/Homebrew/cask/cask.rb Outdated Show resolved Hide resolved

Library/Homebrew/cask/cask.rb Outdated Show resolved Hide resolved

SMillerDev force-pushed the feat/cask/appimage branch 3 times, most recently from 9dcac65 to 0c8c28c Compare October 21, 2025 16:38

SMillerDev force-pushed the feat/cask/appimage branch from 0c8c28c to 4b7f3af Compare October 21, 2025 16:52

feat: add appimage support for linux

06e8a20

SMillerDev force-pushed the feat/cask/appimage branch from 4b7f3af to 06e8a20 Compare October 21, 2025 16:53

MikeMcQuaid changed the title ~~feat: add appimage support for linux~~ Add appimage support for linux Oct 22, 2025

MikeMcQuaid reviewed Oct 22, 2025

View reviewed changes

	# we don't need to run simulated archs on macOS Sequoia
	# we don't need to run simulated archs on macOS Sequoia
	# because it has a GitHub hosted x86_64 runner

Uh oh!

Add appimage support for linux #20334

Are you sure you want to change the base?

Add appimage support for linux #20334

Uh oh!

Conversation

SMillerDev commented Jul 30, 2025

Uh oh!

MikeMcQuaid commented Jul 31, 2025

Uh oh!

SMillerDev commented Jul 31, 2025

Uh oh!

MikeMcQuaid commented Jul 31, 2025

Uh oh!

SMillerDev commented Aug 1, 2025

Uh oh!

github-actions bot commented Aug 23, 2025

Uh oh!

SMillerDev commented Aug 23, 2025

Uh oh!

github-actions bot commented Sep 14, 2025

Uh oh!

SMillerDev commented Sep 14, 2025

Uh oh!

SMillerDev commented Oct 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SMillerDev commented Oct 21, 2025

Uh oh!

MikeMcQuaid left a comment

Choose a reason for hiding this comment

Uh oh!

MikeMcQuaid Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

MikeMcQuaid Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

SMillerDev Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

MikeMcQuaid Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

SMillerDev Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

MikeMcQuaid Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants