Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xorg: Handle archive.mesa3d.org URLs #19010

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

samford
Copy link
Member

@samford samford commented Dec 27, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The mesa formula currently uses a mesa.freedesktop.org/archive/ stable URL but it redirects to archive.mesa3d.org. Upstream links to archive.mesa3d.org as the location to find Mesa releases, so we should update the formula URLs accordingly.

This updates the Xorg strategy to be able to handle archive.mesa3d.org URLs, so livecheck will continue to be able to check mesa without needing a one-off livecheck block. [This would also work for mesalib-glw (which has an archive.mesa3d.org stable URL) but that formula is deprecated.]

@samford samford force-pushed the livecheck/xorg-handle-mesa-urls branch from a5ba393 to 5ed6d43 Compare December 27, 2024 16:49
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you!

The `mesa` formula currently uses a mesa.freedesktop.org/archive/
`stable` URL but it redirects to archive.mesa3d.org. Upstream links
to archive.mesa3d.org as the location to find Mesa releases, so we
should update the formula URLs accordingly.

This updates the `Xorg` strategy to be able to handle
archive.mesa3d.org URLs, so livecheck will continue to be able to
check `mesa` without needing a one-off `livecheck` block. [This would
also work for `mesalib-glw` (which has an archive.mesa3d.org `stable`
URL) but that formula is deprecated.]
@samford samford force-pushed the livecheck/xorg-handle-mesa-urls branch from 5ed6d43 to 260698b Compare December 28, 2024 14:58
@samford
Copy link
Member Author

samford commented Dec 28, 2024

The latest push reworks URL_MATCH_REGEX to deduplicate the trailing /(?:[^/]+/)*#{MODULE_REGEX.source.strip} part. This maintains existing behavior but makes the regex a little easier to read.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Dec 30, 2024
Merged via the queue into master with commit 5013c44 Dec 30, 2024
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the livecheck/xorg-handle-mesa-urls branch December 30, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants