-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elimination principles for GroupCoeq #2184
Merged
Alizter
merged 12 commits into
HoTT:master
from
Alizter:ps/rr/constructors_and_functoriality_for_groupcoeq
Mar 16, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d7356e9
constructors and functoriality for GroupCoeq
Alizter d159e72
replace ugly change with explicit wildcat term
Alizter bd5c53b
Groups/FreeProduct: use $-> to simplify later goals; change WildCat i…
jdchristensen ebb73ff
GroupCoeq: slightly simplify one proof
jdchristensen 9193956
FreeProduct: change Global Instances to Local
jdchristensen 2e82f42
add comment about unifying equiv_groupcoeq_rec
Alizter dc15a84
add comment about complicated wildcat term
Alizter d0c7d05
improve proof of equiv_groupcoeq_rec
Alizter 8b63aec
FreeProduct, GroupCoeq: speed up/simplify some proofs
jdchristensen dd823b0
Move FreeProduct_rec after FreeProduct_ind*
jdchristensen 7fdcbaf
FreeProduct: split Section for speed and improve implicit arguments
jdchristensen 43e5cd4
FreeProduct, GroupCoeq: fix nrapply warnings
jdchristensen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised by how slow the above is. I tried various things, and couldn't improve it. Even providing the term with
exact_no_check
and all implicit arguments is slow: