-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update regex of media module to detect additional domains #290
Conversation
Update regex patterns to detect additional domains for Instagram and Twitter links. * Update the regex pattern in `src/korone/modules/medias/handlers/instagram.py` to detect `ddinstagram.com` links. * Update the regex pattern in `src/korone/modules/medias/handlers/twitter.py` to detect `vxtwitter.com`, `fxtwitter.com`, `fixupx.com`, and `fixvx.com` links.
Reviewer's Guide by SourceryThis pull request updates the regular expressions used to detect Instagram and Twitter links in the media module. The changes add support for additional domains, ensuring that the application can properly identify and handle links from these sources. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @HitaloM - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a unit test to verify the new regex patterns.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Update regex patterns to detect additional domains for Instagram and Twitter links.
src/korone/modules/medias/handlers/instagram.py
to detectddinstagram.com
links.src/korone/modules/medias/handlers/twitter.py
to detectvxtwitter.com
,fxtwitter.com
,fixupx.com
, andfixvx.com
links.Summary by Sourcery
Enhancements: