Refactor when to use setLastFileOpened

HiromuHota · Jul 14, 2017 · a5536a4 · a5536a4
1 parent 8a8a74d
commit a5536a4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/ui/src/org/pentaho/di/ui/spoon/Spoon.java b/ui/src/org/pentaho/di/ui/spoon/Spoon.java
@@ -7989,6 +7989,7 @@ public void loadLastUsedFiles() {
             || lastUsedFile.isSourceRepository() && rep != null
             && rep.getName().equals( lastUsedFile.getRepositoryName() ) ) {
             loadLastUsedFile( lastUsedFile, rep == null ? null : rep.getName(), false );
+            setLastFileOpened( lastUsedFile.getFilename() );
           }
         } catch ( Exception e ) {
           hideSplash();

diff --git a/ui/src/org/pentaho/di/ui/spoon/WebSpoonEntryPoint.java b/ui/src/org/pentaho/di/ui/spoon/WebSpoonEntryPoint.java
@@ -79,19 +79,12 @@ protected void createContents( Composite parent ) {
       LogChannel.GENERAL.logError( "Error calling extension points", e );
     }
 
+    // For VFS browser, set the user data directory. This will be overwritten by the last open file if exists.
+    Spoon.getInstance().setLastFileOpened( Const.getKettleUserDataDirectory() );
+
     // Load last used files
     Spoon.getInstance().loadLastUsedFiles();
 
-    // For VFS browser set the last open file if exists, otherwise set the user data directory
-    Spoon.getInstance().setLastFileOpened( Const.getKettleUserDataDirectory() );
-    List<LastUsedFile> lastUsedFiles = Spoon.getInstance().getProperties().getOpenTabFiles();
-    if ( lastUsedFiles.size() != 0 ) {
-      LastUsedFile lastUsedFile = lastUsedFiles.get( lastUsedFiles.size() - 1 );
-      if ( !lastUsedFile.isSourceRepository() ) {
-        Spoon.getInstance().setLastFileOpened( lastUsedFile.getFilename() );
-      }
-    }
-
     /*
      *  The following lines are webSpoon additional functions
      */