Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the Norwegian Bokmål (Norsk Bokmål) translation of Puter #1093

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

AryanTavish
Copy link
Contributor

Done with the translation and also optimized the billing section
Issue 857
#857

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
All committers have signed the CLA.

@jelveh
Copy link
Contributor

jelveh commented Jan 17, 2025

Thank you for contributing this translation!

One small issue to fix: The billing section is currently structured as an object (billing = { ... }), but it needs to be formatted as individual string keys like the English version, where each key follows the pattern 'billing.key_name'. This is important because using actual nested objects would cause issues with the translation system.

For example, instead of:

billing = {
    change_payment_method: "Endre",
    // ...
}

It should be:

'billing.change_payment_method': "Endre",
// ...

Could you update the billing section to match this format? Once that's fixed, the translation will be ready to merge. Thanks again for your contribution!

For example, instead of:

billing = {
    change_payment_method: "Endre",
    // ...
}
changed to:

'billing.change_payment_method': "Endre",
// ...
@AryanTavish
Copy link
Contributor Author

sure thing! , updated the commit :)

@jelveh jelveh merged commit f13fa25 into HeyPuter:main Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants