Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Add context menu to search results for better file navigation (#… #1049

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mariatouil
Copy link
Contributor

Summary

This Pull Request adds a context menu to search result items, improving file navigation as requested in #876. Additionally, hover effects have been added to enhance the visual feedback when interacting with search results.

Features Implemented

  • Context Menu:
    • Appears on right-click of a search result.
    • Includes actions:
      • Open File: Opens the file directly (same as left-click).
      • Open Containing Folder: Navigates to the parent directory and highlights the file.
  • Hover Effects:
    • When a user hovers over a search result, the item gets a visual highlight by adding the search-result-active class.
    • The highlight is removed when the user stops hovering.

Testing

  • Tested with various file types and directory structures.
  • Confirmed correct behavior in both actions.
image image image

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2024

CLA assistant check
All committers have signed the CLA.

@mariatouil
Copy link
Contributor Author

@jelveh
Hello, I have resolved the conflicts. Could you please review and merge it when you get a chance?

@jelveh
Copy link
Contributor

jelveh commented Dec 27, 2024

This PR is changing a large amount of existing code. E.g. License header,... any reason for that?

@mariatouil
Copy link
Contributor Author

mariatouil commented Dec 27, 2024

@jelveh I just made a new commit to add the license back. I accidentally removed it earlier—sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants