Added threading feature. #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on a project at my workplace, I found this library very useful.
I have added the threading feature. The user needs to create an instance of Subset of Consumer class. He can then call the .start_consumer() instance method which will intrinsically create a thread if the threaded variable is set to True . The user has the option to create a daemon or non-daemon thread.
The user need not worry about joining or stopping the thread manually at the time of program exit. It is done automatically. It can be done manually if they wish to.
The changes have passed all the tests. Let me know if I have to add any tests. I will change the documentation as soon as you say the changes are ok.
If there are any changes you would like me to make, please let me know.