feat(ModLaunch):允许不使用 JLW #5785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit:好吧是 Visual Studio 残留的源代码 |
|
🤔 现在这个实现感觉不是很好，应该改成 combobox ，分别写 启用/禁用/跟随默认设置 |
Pigeon0v0
reviewed
Mar 6, 2025
| @@ -252,6 +252,8 @@ | |||
| ToolTip="警告：强烈推荐在版本设置中关闭特定版本的警告，而不是在这里关闭所有版本的警告！
如果在设置中手动选择了与当前版本不兼容的 Java，则自动跳过兼容性警告弹窗，强制使用手动选择的 Java。" /> | |||
| <local:MyCheckBox Text="关闭文件校验" x:Name="CheckAdvanceAssets" Tag="LaunchAdvanceAssets" | |||
| ToolTip="警告：强烈推荐在版本设置中关闭特定版本的校验，而不是在这里关闭所有版本的校验！
完全不更改 assets；不校验 libraries、第三方登录库与版本主 jar 文件是否被修改。
如果你没有修改相关文件，请勿勾选此项。" /> | |||
| <local:MyCheckBox Text="使用 JLW" x:Name="CheckAdvanceUseLaunchWrapper" Tag="LaunchAdvanceUseLaunchWrapper" Margin="50,0,0,0" | |||
| ToolTip="警告：强烈推荐在版本设置中关闭特定版本的校验，而不是在这里关闭所有版本的校验！
在启动时额外加载 JLW 来处理中文目录。
如果服务器没有使用反作弊，请勿取消勾选此项。" /> | |||
There was a problem hiding this comment.
Suggested change
| ToolTip="警告：强烈推荐在版本设置中关闭特定版本的校验，而不是在这里关闭所有版本的校验！
在启动时额外加载 JLW 来处理中文目录。
如果服务器没有使用反作弊，请勿取消勾选此项。" /> | |
| ToolTip="警告：强烈推荐在版本设置中禁用特定版本的 JLW，而不是在这里为所有版本禁用！
在启动时额外加载 Java Wrapper 来处理中文目录。
仅建议在有特殊需要时勾选此项。" /> |
应该把这个 CheckBox 改成勾选 = 禁用，可能会更符合预期
可以参考 CE
There was a problem hiding this comment.
我现在考虑是不是应该做成列表框的形式，因为现有判断条件似乎总会让版本或全局设置无效
等周末了再认真考虑一下怎么写比较好
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #417