Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新功能:加入一系列简单的管理版本资源界面 #4770

Open
wants to merge 57 commits into
base: main
Choose a base branch
from

Conversation

tangge233
Copy link
Contributor

@tangge233 tangge233 commented Sep 21, 2024

前言

PCL2 竟然这么久还没有简单的版本资源管理界面

进度

  • 存档管理
  • 截图管理
  • 资源包管理
  • 光影管理
  • 启动器内粘贴操作

本 PR 有相关资源图标参考

预览

image

image

image

image

提前体验

此功能已合并入 PCL-CE,下载社区版本的 PCL 可以提前体验此功能

合并提示

使用下面的命令可合并本 PR 而不是 CV qwq

git pull https://github.com/tangge233/PCL2.git InstanceResource

@3gf8jv4dv
Copy link
Collaborator

Although... but LTCatt has rejected some of these features.

@3gf8jv4dv 3gf8jv4dv added · 新功能 社区处理中 社区正在调查或处理该项 labels Sep 21, 2024
@tangge233
Copy link
Contributor Author

tangge233 commented Sep 21, 2024

不会加入非常复杂的内容,只有简单的查看(不会有非常详细的信息,比如存档内容、在线资源指向……)、删除、另存为什么的……

@3gf8jv4dv
Copy link
Collaborator

3gf8jv4dv commented Sep 21, 2024

不会加入非常复杂的内容,只有简单的查看(不会有非常详细的信息,比如存档内容、在线资源指向……)、删除、另存为什么的……

Waiting for your good news.

@LTCatt
Copy link
Member

LTCatt commented Sep 21, 2024

我自己应该不会考虑添加这些功能……不过可以加进 PR Collection 啥的(

@allMagicNB
Copy link
Contributor

刚发现 7965ca8 干爆了我 PR Collection
image

@tangge233 tangge233 marked this pull request as ready for review September 21, 2024 13:20
@3gf8jv4dv
Copy link
Collaborator

So beautiful!!! I like that. Lightweight and practical.

Review comments will be provided later (if available).

@Chiloven945

This comment was marked as resolved.

资源包显示图标
部分图标修改
部分文案修改
Copy link
Collaborator

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I click on the resource pack

程序出现未知错误:Could not find a part of the path '*:\PCL\.minecraft\versions\*\PCL\Resourcepacks\'.
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.Directory.Delete(String fullPath, String userPath, Boolean recursive, Boolean checkHost)
   at PCL.PageVersionResourcePack.LoadFileList()
   at PCL.PageVersionResourcePack.Reload()
   at PCL.PageVersionResourcePack.PageSetupLaunch_Loaded(Object sender, RoutedEventArgs e)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.BroadcastEventHelper.BroadcastEvent(DependencyObject root, RoutedEvent routedEvent)
   at System.Windows.BroadcastEventHelper.BroadcastLoadedEvent(Object root)
   at MS.Internal.LoadedOrUnloadedOperation.DoWork()
   at System.Windows.Media.MediaContext.FireLoadedPendingCallbacks()
   at System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
   at System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
   at System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
错误类型:System.IO.DirectoryNotFoundException

Copy link
Collaborator

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some opinions.

After copying the screenshot, no screenshot is seen in the Win+V clipboard interface. However, the screenshot function of some software can be used to view the corresponding screenshot on the above interface after taking the screenshot. Is it possible to implement it here?

For each screenshot in the screenshot interface, can you add rounded corners around the preview? The current effect looks a bit abrupt compared to the UI elements.

@tangge233
Copy link
Contributor Author

@3gf8jv4dv

When I try to add rounded corners around the picture, the UI becomes strange.

image


And there seems some issues with windows clipboard, it does not work very well sometimes.

@tangge233
Copy link
Contributor Author

经过多轮开发,此 PR 已较完善实现相关功能

@Txt-Text
Copy link
Contributor

几个月了,所以这个功能最终会合并到正式版吗🤔

@tangge233
Copy link
Contributor Author

几个月了,所以这个功能最终会合并到正式版吗🤔

会的。

最近社区版测试出了这个功能一些小问题,近期还会同步一次修复代码到这里(

@LTCatt LTCatt added ✨ 尝鲜特性 尝鲜特性相关内容 and removed 暂无计划 短期内没有制作该项的计划 labels Feb 12, 2025
@LTCatt
Copy link
Member

LTCatt commented Feb 17, 2025

资源包和光影包其实可以完全按照 Mod 页面的方式来,它们也可以获取到 CF/Modrinth 上的工程,所以也可以跳转到详情页面以及更新啥的。
截图和存档管理我觉得确实没啥必要,加个打开文件夹入口感觉就够了,可能之后也不会合……

@tangge233
Copy link
Contributor Author

tangge233 commented Feb 19, 2025

按照 Mod 页面的方式来

思考了下,决定改一个 ModLocalComp.vb 代替 ModMod.vb,这样弄一个通用的工程资源查看就可以减少重复造的轮子(

截图和存档管理

给个简单的查看问题也不大?

Edit: 好像可行性非常大,等我在社区版测试下看看

@LTCatt
Copy link
Member

LTCatt commented Feb 19, 2025

Mod/资源包/光影包 的代码确实建议合并到一个 Page,不然会重复三次……

@tangge233
Copy link
Contributor Author

tangge233 commented Feb 20, 2025

目前效果 还不错,除了 Curseforge 不听话以外……

image


此外,此 PR 建议在资源下载合并之后合并,因为缺少很多必要的前置(比如标签、工程类型、页面跳转)

@3gf8jv4dv 3gf8jv4dv mentioned this pull request Feb 25, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
· 新功能 ✨ 尝鲜特性 尝鲜特性相关内容
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants