Skip to content

fix: address logically incorrect config values in app/build.gradle.kts#17

Merged
HereLiesAz merged 1 commit into
masterfrom
fix/missing-import-properties-8962130130998448006
May 14, 2026
Merged

fix: address logically incorrect config values in app/build.gradle.kts#17
HereLiesAz merged 1 commit into
masterfrom
fix/missing-import-properties-8962130130998448006

Conversation

@HereLiesAz

Copy link
Copy Markdown
Owner

No description provided.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @HereLiesAz, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@HereLiesAz HereLiesAz merged commit 646e348 into master May 14, 2026
3 of 4 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors app/build.gradle.kts to use dynamic versioning variables and modifies the loading of local properties. The review feedback suggests removing a redundant import and reverting the scope of the local properties file variable to maintain a cleaner script namespace.

Comment thread app/build.gradle.kts
@@ -1,3 +1,5 @@
import java.util.Properties

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The import of java.util.Properties is redundant in Gradle Kotlin DSL scripts, as java.util.* is already included in the default imports. Removing it keeps the script cleaner and adheres to idiomatic Gradle Kotlin DSL practices.

Comment thread app/build.gradle.kts
Comment on lines +16 to 20
val localPropertiesFile = project.rootProject.file("local.properties")
val localProperties = Properties().apply {
val localPropertiesFile = project.rootProject.file("local.properties")
if (localPropertiesFile.exists()) {
localPropertiesFile.inputStream().use { load(it) }
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Moving localPropertiesFile to the script scope is unnecessary if it is only used to load the localProperties object. It is better to keep its scope restricted to the apply block to avoid polluting the script's namespace. Additionally, project.rootProject can be simplified to rootProject as the project prefix is redundant in this context.

val localProperties = Properties().apply {
    val localPropertiesFile = rootProject.file("local.properties")
    if (localPropertiesFile.exists()) {
        localPropertiesFile.inputStream().use { load(it) }
    }
}

@HereLiesAz HereLiesAz deleted the fix/missing-import-properties-8962130130998448006 branch May 14, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant