Skip to content

Fix missing import in app/build.gradle.kts #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HereLiesAz merged 3 commits into from
May 14, 2026
Merged

Fix missing import in app/build.gradle.kts #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9323314
fix: add missing import for Properties in build.gradle.kts
HereLiesAz May 13, 2026
8486452
ci: fix azure static web apps deployment on missing secrets
HereLiesAz May 13, 2026
751d986
ci: fix unexpected input skip_deploy_on_missing_secrets in Azure Stat…
HereLiesAz May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/azure-staticwebapp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ jobs:
api_location: ${{ env.API_LOCATION }}
app_artifact_location: ${{ env.APP_ARTIFACT_LOCATION }}
###### End of Repository/Build Configurations ######
env:
skip_deploy_on_missing_secrets: true

close_pull_request_job:
permissions:
Expand All @@ -68,3 +70,5 @@ jobs:
with:
azure_static_web_apps_api_token: ${{ env.AZURE_STATIC_WEB_APPS_API_TOKEN }} # secret containing api token for app
action: "close"
env:
skip_deploy_on_missing_secrets: true
2 changes: 2 additions & 0 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import java.util.Properties

@gemini-code-assist gemini-code-assist Bot May 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While adding the import java.util.Properties fixes the compilation error, there are two significant logic issues in the code that uses these properties:

  1. Incorrect File Loading: On line 19, localProperties is being loaded from versionPropsFile instead of localPropertiesFile. This means local properties are ignored and version properties are re-loaded into the wrong variable.
  2. Hardcoded Versioning: The versionCode and versionName in the defaultConfig block (lines 47-48) are hardcoded to 1 and "1.0". They should be updated to use the currentVersionCode and currentVersionName variables calculated on lines 23 and 38 to make the auto-increment logic effective.


plugins {
alias(libs.plugins.androidApplication)
alias(libs.plugins.kotlinAndroid)
Expand Down
Loading