Fix background color and add APK build action#14
Conversation
- Changed Material3 default background and surface color in `Theme.kt` to #FFFFFF. - Added GitHub action `.github/workflows/build-apk.yml` to automatically build and publish a pre-release debug APK on push. - Used `secrets.GH_TOKEN` for GitHub release creation to resolve permission issues. - Removed broken `jules-pr-lifecycle` and `assign-jules` actions. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @HereLiesAz, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
HereLiesAz
deleted the
jules-fix-bg-color-and-add-apk-action-5856042109503101069
branch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the LightColorScheme in Theme.kt by explicitly defining background and surface colors. The reviewer suggests using the more idiomatic Color.White instead of hex literals and recommends centralizing these color definitions in Color.kt to improve maintainability and consistency.
| background = Color(0xFFFFFFFF), | ||
| surface = Color(0xFFFFFFFF) |
There was a problem hiding this comment.
Using Color.White is more idiomatic and readable in Jetpack Compose than the hex literal Color(0xFFFFFFFF). Furthermore, to maintain consistency with the project's established structure, consider updating the existing color constants in Color.kt (such as ScreenBackground or CardBackground) and referencing them here instead of hardcoding hex values directly in the theme definition.
| background = Color(0xFFFFFFFF), | |
| surface = Color(0xFFFFFFFF) | |
| background = Color.White, | |
| surface = Color.White |
1 participant
Theme.ktto #FFFFFF..github/workflows/build-apk.ymlto automatically build and publish a pre-release debug APK on push.secrets.GH_TOKENfor GitHub release creation to resolve permission issues.jules-pr-lifecycleandassign-julesactions.