Perf/uniform solver #77
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to fix type instabilities in
HerbConstraints.The root cause is the
UniformIteratornot knowing what subtype ofAbstractRuleNodeit faces. However, these are onlyStateHoleorRuleNode.We now transform every
RuleNodeto aStateHolefirst, and then only handle this case.TODO:
StateHole(..., ::Rulenode)does not know the domain size, which hence has to be passed. Let us find a cleaner solution to this.