fix: advance delivery indicator past Sent and add distinct double-tick#171
Open
MasterK0927 wants to merge 1 commit into
Open
fix: advance delivery indicator past Sent and add distinct double-tick#171MasterK0927 wants to merge 1 commit into
MasterK0927 wants to merge 1 commit into
Conversation
The notify_message_delivery zome input uses serde rename_all=camelCase, so it expects messageRecord, but the client sent message_record. The payload failed to deserialize, the call threw, delivery acks were never recorded, and the indicator was stuck on a single tick. Send messageRecord to match. Also render a dedicated double-check glyph for delivered messages instead of overlapping two single checks.
There was a problem hiding this comment.
Pull request overview
Fixes delivery-ack payload deserialization by aligning the UI payload shape with the backend’s serde(rename_all = "camelCase") expectations, and improves the UI delivery indicator by using a dedicated double-check glyph.
Changes:
- Send
messageRecord(camelCase) instead ofmessage_recordwhen callingnotify_message_delivery, so acks can be recorded and delivery status can advance beyond “Sent”. - Update the delivery status UI to render a single icon that switches between
checkMarkanddoubleCheck. - Add a new
doubleCheckSVG icon asset.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/src/store/ConversationMessageStore.ts | Updates zome call payload key to messageRecord so delivery notifications deserialize correctly. |
| ui/src/routes/conversations/[id]/DeliveryStatusIndicator.svelte | Switches from overlapping two checkmarks to selecting a single icon (checkMark / doubleCheck) and adjusts sizing/spacing. |
| ui/src/lib/types.ts | Renames NotifyMessageDeliveryInput field to messageRecord to match the backend payload shape. |
| ui/src/lib/svgIcons.ts | Adds a doubleCheck SVG icon for delivered states. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@MasterK0927 Thanks for the PR. Could you please create a dev releas(v0.12.7-dev) to test the message delivery feature and also check that the synchronization is intact? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notify_message_delivery zome input uses serde rename_all=camelCase, so it expects messageRecord, but the client sent message_record. The payload failed to deserialize, the call threw, delivery acks were never recorded, and the indicator was stuck on a single tick. Send messageRecord to match.
Also render a dedicated double-check glyph for delivered messages instead of overlapping two single checks.
Summary
TODO: