Feature optional 6 columns layout for app grid & Fix weather widget toggl#356
Open
erascape wants to merge 3 commits into
Open
Feature optional 6 columns layout for app grid & Fix weather widget toggl#356erascape wants to merge 3 commits into
erascape wants to merge 3 commits into
Conversation
Adds a "Use 6 columns" toggle in design settings. When enabled, the app grid uses 6 columns instead of the width-based default (4/5/8). The setting persists and applies live without restart. Change-Id: I14cd784d022303b8924a6a9c992c579653518d6a Signed-off-by: erascape <erascape@proton.me>
The toggle wrote to weatherWdtIsVisible (a typo — should be Wgt), which silently created an undeclared property on the Settings store instead of updating the real one. Result: toggling the weather widget in design settings appeared to work but never affected visibility or persisted across launches. Hence fix it Change-Id: Ie59860f8aec50a7d1c7f4b19e9f1d295ec66d3c4 Signed-off-by: erascape <erascape@proton.me>
Contributor
Author
|
This pull request includes
Please review thankyou |
Contributor
Author
|
@wurzer Dr. Wurzer any update on the pull request? |
Contributor
|
This proposal would mean, that 6 columns would also be used on a tablet. I suggest to use a smarter setting, the would add more columns based on the sepected item and font sizing setting for the display. |
Replaces the binary "Use 6 columns" toggle with a screen- and font-aware column computation. The auto mode picks columns based on available width and a user-adjustable font scale, so tablets stay roomy (still 8 cols by default) while large phones get 6, and small phones keep 4-5. A manual override slider (Auto / 4 / 5 / 6 / 7 / 8) lets the user force a specific count. A separate font-scale slider (80%-140%) also resizes the app labels and feeds back into the auto column calculation. Change-Id: I5d928ac7121819c12fc5713547f4459ed9c6f6de
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.