-
Notifications
You must be signed in to change notification settings - Fork 457
added more model versions #5293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @chitalian's task —— View job Code Review CompleteTodo List:
Review AnalysisThis PR adds comprehensive support for new OpenAI model versions across GPT-4o, GPT-4.1, GPT-5, and GPT-5.1 families. The implementation follows Helicone's established patterns for model versioning with dated snapshots. Critical Issues Found🚨 Future Creation Dates
Code Quality IssuesStyle Consistency
Parameter Support Variations
Security & Performance✅ Security: No security issues found - all pricing and configuration data is static Positive Aspects
Score: 6/10 - Functional implementation with several consistency issues requiring attention Suggestions Summary:
|
Greptile OverviewGreptile SummaryThis PR adds support for new OpenAI model versions across multiple GPT families in Helicone's cost calculation system. The changes introduce dated model variants including GPT-4o search preview models (2025-03-11), GPT-4.1 versions (2025-04-14 and 2024-07-18), GPT-5 family snapshots (2025-08-07), and GPT-5.1 variant (2025-11-13). These additions follow Helicone's established pattern for model versioning, where specific dated versions are created as immutable snapshots while maintaining references to their base models through The model configurations are comprehensive, spanning multiple providers (OpenAI, Azure, OpenRouter, Helicone) with consistent pricing, rate limits, context lengths, and parameter support. Notable additions include search-enabled GPT-4o variants with web search capabilities priced at $10 per1000 searches. This change enables accurate cost tracking and billing for users who reference specific model versions rather than the base model names, supporting both compatibility and reproducibility in LLM applications. Important Files Changed
Confidence score: 4/5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 files reviewed, 1 comment
| tokenizer: "GPT", | ||
| }, | ||
| "gpt-5.1-2025-11-13": { | ||
| name: "OpenAI GPT-5.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Model name is identical to the base model (line 5). Consider adding version info to distinguish this specific dated version, e.g., 'OpenAI GPT-5.1 (2025-11-13)'.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/cost/models/authors/openai/gpt-5.1/models.ts
Line: 57:57
Comment:
**style:** Model name is identical to the base model (line 5). Consider adding version info to distinguish this specific dated version, e.g., 'OpenAI GPT-5.1 (2025-11-13)'.
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Ticket
Link to the ticket(s) this pull request addresses.
Component/Service
What part of Helicone does this affect?
Type of Change
Testing
Technical Considerations
Dependencies
Deployment Notes
Context
Why are you making this change?
Screenshots / Demos
Misc. Review Notes