Integrate Canopy Wave as a provider for ZAI GLM-4.6 #5292

cynthia-lixinyi · 2025-11-25T00:29:10Z

Ticket

Link to the ticket(s) this pull request addresses.

Component/Service

What part of Helicone does this affect?

Type of Change

Testing

Technical Considerations

Database migrations included (if needed)
API changes documented
Breaking changes noted
Performance impact assessed
Security implications reviewed

Dependencies

No external dependencies added
Dependencies added and documented
Environment variables added/modified

Deployment Notes

No special deployment steps required
Database migrations need to run
Environment variable changes required
Coordination with other teams needed

Context

Why are you making this change?
Integrate Canopy Wave as a provider for ZAI GLM-4.6

Screenshots / Demos

Before	After

Misc. Review Notes

vercel · 2025-11-25T00:29:17Z

@cynthia-lixiny07 is attempting to deploy a commit to the Helicone Team on Vercel.

A member of the Team first needs to authorize it.

greptile-apps · 2025-11-25T00:32:23Z

Greptile Overview

Greptile Summary

Integrates Canopy Wave as a new provider for ZAI GLM-4.6 model with pricing, configuration, and comprehensive test coverage.

Key Changes:

Added CanopyWaveProvider class with API endpoint configuration
Registered provider across cost calculation, usage processing, and UI systems
Configured glm-4.6 endpoint with Canopy Wave pricing ($0.00000045 input / $0.0000015 output)
Added 400+ lines of integration tests covering success and error scenarios

Issues Found:

Critical: buildUrl method signature in packages/cost/models/providers/canopywave.ts is missing required parameters and type imports, which will cause TypeScript compilation errors
Model ID inconsistency: tests expect zai/glm-4.6 while Novita provider uses zai-org/glm-4.6
Parameter discrepancy: logit_bias supported by Novita but not Canopy Wave

Confidence Score: 1/5

This PR has critical syntax errors that will prevent compilation
The CanopyWaveProvider.buildUrl method has an incorrect signature that doesn't match the BaseProvider abstract class, missing both required parameters (endpoint, requestParams) and the necessary type imports. This will cause TypeScript compilation to fail. Additionally, there's a potential model ID mismatch in tests that needs verification.
packages/cost/models/providers/canopywave.ts requires immediate fixes for TypeScript compilation errors. Verify model ID consistency in worker/test/ai-gateway/registry-zai.spec.ts

Important Files Changed

File Analysis

Filename	Score	Overview
packages/cost/models/providers/canopywave.ts	1/5	New provider class with critical issues: incorrect `buildUrl` signature and missing type imports
packages/cost/models/authors/zai/glm-4/endpoints.ts	3/5	Added Canopy Wave endpoint config for glm-4.6 with potential parameter inconsistency (logit_bias)
packages/cost/models/provider-helpers.ts	5/5	Added Canopy Wave provider mapping - implementation looks correct and consistent with existing patterns
worker/test/ai-gateway/registry-zai.spec.ts	3/5	Added comprehensive test suite for Canopy Wave integration with potential model ID mismatch

Sequence Diagram

sequenceDiagram
    participant Client
    participant Gateway as AI Gateway
    participant Registry as Model Registry
    participant Provider as CanopyWaveProvider
    participant API as Canopy Wave API

    Client->>Gateway: POST /chat/completions<br/>model: glm-4.6/canopywave
    Gateway->>Registry: Lookup model config
    Registry->>Registry: Match "glm-4.6:canopywave"<br/>from endpoints.ts
    Registry-->>Gateway: Return config<br/>(providerModelId: zai-org/glm-4.6)
    
    Gateway->>Provider: buildUrl(endpoint, params)
    Provider-->>Gateway: https://inference.canopywave.io/v1/chat/completions
    
    Gateway->>Provider: authenticate(context)
    Provider-->>Gateway: Authorization: Bearer <api-key>
    
    Gateway->>Provider: buildRequestBody(endpoint, context)
    Provider-->>Gateway: JSON with model: zai-org/glm-4.6
    
    Gateway->>API: POST with transformed request
    API-->>Gateway: Response
    Gateway-->>Client: Return response with usage/cost

greptile-apps

_{10 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2025-11-25T00:32:20Z

packages/cost/models/providers/canopywave.ts

+  buildUrl(): string {
+    return `${this.baseUrl}v1/chat/completions`;
+  }


syntax: buildUrl method signature doesn't match BaseProvider interface - missing required endpoint and requestParams parameters

Suggested change

buildUrl(): string {

return `${this.baseUrl}v1/chat/completions`;

}

buildUrl(endpoint: Endpoint, requestParams: RequestParams): string {

return `${this.baseUrl}v1/chat/completions`;

}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/cost/models/providers/canopywave.ts Line: 10:12 Comment: **syntax:** `buildUrl` method signature doesn't match `BaseProvider` interface - missing required `endpoint` and `requestParams` parameters ```suggestion buildUrl(endpoint: Endpoint, requestParams: RequestParams): string { return `${this.baseUrl}v1/chat/completions`; } ``` How can I resolve this? If you propose a fix, please make it concise.

fixed. (18a828d)

greptile-apps · 2025-11-25T00:32:21Z

packages/cost/models/providers/canopywave.ts

@@ -0,0 +1,13 @@
+import { BaseProvider } from "./base";


syntax: missing imports for Endpoint and RequestParams types that are required by the buildUrl method signature

Suggested change

import { BaseProvider } from "./base";

import { BaseProvider } from "./base";

import type { Endpoint, RequestParams } from "../types";

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/cost/models/providers/canopywave.ts Line: 1:1 Comment: **syntax:** missing imports for `Endpoint` and `RequestParams` types that are required by the `buildUrl` method signature ```suggestion import { BaseProvider } from "./base"; import type { Endpoint, RequestParams } from "../types"; ``` How can I resolve this? If you propose a fix, please make it concise.

fixed. (18a828d)

greptile-apps · 2025-11-25T00:32:22Z

packages/cost/models/authors/zai/glm-4/endpoints.ts

+    supportedParameters: [
+      "functions",
+      "structured_outputs",
+      "reasoning",
+      "tool_choice",
+      "tools",
+      "response_format",
+      "max_tokens",
+      "temperature",
+      "top_p",
+      "stop",
+      "frequency_penalty",
+      "presence_penalty",
+      "seed",
+      "top_k",
+      "min_p",
+      "repetition_penalty",
+    ],


style: check that logit_bias parameter (supported by Novita on line 37) should be included or excluded from Canopy Wave's supportedParameters list

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/cost/models/authors/zai/glm-4/endpoints.ts Line: 58:75 Comment: **style:** check that `logit_bias` parameter (supported by Novita on line 37) should be included or excluded from Canopy Wave's `supportedParameters` list How can I resolve this? If you propose a fix, please make it concise.

fixed. (39a1136)

greptile-apps · 2025-11-25T00:32:22Z

worker/test/ai-gateway/registry-zai.spec.ts

+              {
+                url: "https://inference.canopywave.io/v1/chat/completions",
+                response: "success",
+                model: "zai/glm-4.6",


style: verify the correct model ID - Novita tests use zai-org/glm-4.6 (line 34-35) but Canopy Wave tests use zai/glm-4.6

Prompt To Fix With AI

This is a comment left during a code review. Path: worker/test/ai-gateway/registry-zai.spec.ts Line: 448:448 Comment: **style:** verify the correct model ID - Novita tests use `zai-org/glm-4.6` (line 34-35) but Canopy Wave tests use `zai/glm-4.6` How can I resolve this? If you propose a fix, please make it concise.

On Canopy Wave's cluster, the model ID for ZAI GLM 4.6 is zai/glm-4.6.

… canopywave

juliettech13 · 2025-11-25T14:54:48Z

yarn.lock

  version "2.0.4"
  resolved "https://registry.yarnpkg.com/zwitch/-/zwitch-2.0.4.tgz#c827d4b0acb76fc3e685a4c6ec2902d51070e9d7"
-  integrity sha512-bXE4cR/kVZhKZX/RjPEflHaKVhUVl85noU3v6b8apfQEc1x4A+zBxjZ4lN8LqGd6WZ3dl98pY4o717VFmoPp+A==
+  integrity sha512-bXE4cR/kVZhKZX/RjPEflHaKVhUVl85noU3v6b8apfQEc1x4A+zBxjZ4lN8LqGd6WZ3dl98pY4o717VFmoPp+A==


Let's remove this file from the PR

cynthia-lixiny07 added 10 commits November 21, 2025 15:15

step 2. create provider definition

921f223

step 3. add provider to index.ts

126efbc

step.5 finished

72ac701

step.7 finished

8867d85

added canopywave logo

311940a

zai glm4.6 canopywave as a provider

c15993e

wrote tests for author zai provider canopy wave

95fdeb5

reformat to minimize diff

a3deba2

reformat

52d41ce

reformat

3500ae2

greptile-apps bot reviewed Nov 25, 2025

View reviewed changes

cynthia-lixinyi and others added 6 commits November 24, 2025 16:39

Merge branch 'Helicone:main' into canopywave

9ea3b1a

fixed provider base url

74f6c45

logit_bias

39a1136

Merge branch 'Helicone:main' into canopywave

5144045

Added endpoint and requestParams as parameters for buildUrl

18a828d

Merge branch 'canopywave' of github.com:cynthia-lixinyi/helicone into…

6d241f1

… canopywave

juliettech13 reviewed Nov 25, 2025

View reviewed changes

cynthia-lixiny07 and others added 4 commits November 25, 2025 14:56

copy the yarn.lock on helicone main branch so that no diff

d0f71e0

stop tracking yarn.lock

3724b1a

Revert yarn.lock to main version

5cca791

Merge branch 'Helicone:main' into canopywave

6927e17

	import { BaseProvider } from "./base";
	import { BaseProvider } from "./base";
	import type { Endpoint, RequestParams } from "../types";

Integrate Canopy Wave as a provider for ZAI GLM-4.6 #5292

Are you sure you want to change the base?

Integrate Canopy Wave as a provider for ZAI GLM-4.6 #5292

Uh oh!

Conversation

cynthia-lixinyi commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ticket

Component/Service

Type of Change

Testing

Technical Considerations

Dependencies

Deployment Notes

Context

Screenshots / Demos

Misc. Review Notes

Uh oh!

vercel bot commented Nov 25, 2025

Uh oh!

greptile-apps bot commented Nov 25, 2025

Greptile Overview

Greptile Summary

Confidence Score: 1/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

cynthia-lixinyi Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

cynthia-lixinyi Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

cynthia-lixinyi Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

cynthia-lixinyi Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

juliettech13 Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cynthia-lixinyi commented Nov 25, 2025 •

edited

Loading

cynthia-lixinyi Nov 25, 2025 •

edited

Loading