-
Notifications
You must be signed in to change notification settings - Fork 457
Sunrun case study #5277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sunrun case study #5277
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Claude finished @juliettech13's task —— View job PR Review CompleteTodo List:
Score: 3/10 - Critical issues prevent mergeTwo critical issues must be fixed before merge: 1. 🚨 Future Customer Date -
|
Greptile OverviewGreptile SummaryThis PR adds a new Sunrun case study to the marketing site, showcasing how Sunrun uses Helicone for caching, observability, and alerting in their AI operations. However, the PR contains two critical issues that need to be addressed:
The case study content itself is well-written and properly structured with customer quotes, feature highlights, and results. The integration into the case studies list is correct. Confidence Score: 1/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Bifrost as Bifrost (Marketing)
participant FileSystem as File System
participant User as Website Visitor
Dev->>FileSystem: Create metadata.json
Dev->>FileSystem: Create src.mdx content
Dev->>FileSystem: Add sunrun.webp logo
Dev->>Bifrost: Update CaseStudies.tsx
Note over Bifrost: Add "sunrun" to case studies array
Dev->>FileSystem: Modify provider-helpers.ts
Note over FileSystem: Unintended: revert kimi-k2 mapping
User->>Bifrost: Visit /customers page
Bifrost->>FileSystem: Load case studies metadata
FileSystem-->>Bifrost: Return all case study data
Bifrost->>Bifrost: Format customerSince dates
Bifrost-->>User: Display case studies grid
Note over User: Sees Sunrun with incorrect<br/>future customer date
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 2 comments
| "claude-3.5-sonnet-20240620": "claude-3.5-sonnet-v2", | ||
| "deepseek-r1": "deepseek-reasoner", | ||
| "kimi-k2": "kimi-k2-0905", | ||
| "kimi-k2": "kimi-k2-0711", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Unrelated change: reverts PR #5249 ("kimi-k2 go to latest") from Nov 14. This changes kimi-k2 mapping from kimi-k2-0905 back to kimi-k2-0711, which appears to be an accidental revert unrelated to the Sunrun case study.
| "kimi-k2": "kimi-k2-0711", | |
| "kimi-k2": "kimi-k2-0905", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/cost/models/provider-helpers.ts
Line: 346:346
Comment:
**logic:** Unrelated change: reverts PR #5249 ("kimi-k2 go to latest") from Nov 14. This changes `kimi-k2` mapping from `kimi-k2-0905` back to `kimi-k2-0711`, which appears to be an accidental revert unrelated to the Sunrun case study.
```suggestion
"kimi-k2": "kimi-k2-0905",
```
How can I resolve this? If you propose a fix, please make it concise.217adf8 to
7e8e5cd
Compare
7e8e5cd to
b57b44c
Compare
Ticket
[SAL-1179] - Sunrun Case Study
Component/Service
What part of Helicone does this affect?
Type of Change
Testing
Technical Considerations
Dependencies
Deployment Notes
Context
Why are you making this change?
Adding Sunrun case study for customer visibility.
Screenshots / Demos