Skip to content

Conversation

@juliettech13
Copy link
Collaborator

Ticket

[SAL-1179] - Sunrun Case Study

Component/Service

What part of Helicone does this affect?

  • Web (Frontend)
  • Jawn (Backend)
  • Worker (Proxy)
  • Bifrost (Marketing)
  • AI Gateway
  • Packages
  • Infrastructure/Docker
  • Documentation

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Performance improvement
  • Refactoring

Testing

  • Added/updated unit tests
  • Added/updated integration tests
  • Tested locally
  • Verified in staging environment
  • E2E tests pass (if applicable)

Technical Considerations

  • Database migrations included (if needed)
  • API changes documented
  • Breaking changes noted
  • Performance impact assessed
  • Security implications reviewed

Dependencies

  • No external dependencies added
  • Dependencies added and documented
  • Environment variables added/modified

Deployment Notes

  • No special deployment steps required
  • Database migrations need to run
  • Environment variable changes required
  • Coordination with other teams needed

Context

Why are you making this change?

Adding Sunrun case study for customer visibility.

Screenshots / Demos

CleanShot 2025-11-21 at 16 55 27@2x

@vercel
Copy link

vercel bot commented Nov 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
helicone Ready Ready Preview Comment Dec 2, 2025 8:04pm
helicone-eu Ready Ready Preview Comment Dec 2, 2025 8:04pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
helicone-bifrost Skipped Skipped Dec 2, 2025 8:04pm

@claude
Copy link
Contributor

claude bot commented Nov 22, 2025

Claude finished @juliettech13's task —— View job


PR Review Complete

Todo List:

  • Read and analyze all changed files
  • Verify issues identified by Greptile
  • Check for additional code quality/security issues
  • Provide comprehensive review feedback with confidence score
  • Give specific suggestions for fixes

Score: 3/10 - Critical issues prevent merge

Two critical issues must be fixed before merge:

1. 🚨 Future Customer Date - bifrost/app/customers/case-studies/sunrun/metadata.json:7

"customerSince": "2025-05-01",  // ❌ May 2025 is in the future

Fix:

"customerSince": "2024-05-01",  // ✅ Correct to 2024

2. 🚨 Unrelated Model Mapping Revert - This PR accidentally reverts a recent change

The file packages/cost/models/provider-helpers.ts contains the correct mapping "kimi-k2": "kimi-k2-0905" but this appears to be an unintended change unrelated to the Sunrun case study. This should be removed from this PR entirely.

Fix: Remove this file from the changeset completely as it's unrelated to the case study.


Additional Issues Found:

3. ⚠️ Inconsistent Asset Paths

  • Case study references: /static/customers/case-studies/sunrun.webp
  • Company logos reference: /static/sunrun.webp

This creates two different Sunrun logos in different locations. Consider consolidating to one canonical location.

4. ✅ What's Working Well:

  • Case study content is well-written with good customer quotes
  • Proper integration into the case studies array
  • Follows existing file structure and naming conventions
  • MDX content follows marketing site patterns
  • Image file size is reasonable (28KB)

Suggestions Summary:

  1. CRITICAL: Fix customerSince date to 2024-05-01
  2. CRITICAL: Remove unrelated packages/cost/models/provider-helpers.ts changes
  3. Consider: Consolidating Sunrun logo asset paths for consistency
  4. Test: Verify case study renders correctly on the website

Once the two critical issues are resolved, this will be a solid addition to the marketing site.


@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 22, 2025

Greptile Overview

Greptile Summary

This PR adds a new Sunrun case study to the marketing site, showcasing how Sunrun uses Helicone for caching, observability, and alerting in their AI operations. However, the PR contains two critical issues that need to be addressed:

  • The customerSince date in metadata.json is set to May 2025, which is in the future (current date is November 2025)
  • An unrelated change to packages/cost/models/provider-helpers.ts reverts a recent update (PR Kimi-k2 go to latest #5249) that changed the kimi-k2 model mapping from kimi-k2-0711 to kimi-k2-0905

The case study content itself is well-written and properly structured with customer quotes, feature highlights, and results. The integration into the case studies list is correct.

Confidence Score: 1/5

  • Not safe to merge - contains incorrect date and unrelated revert
  • Two critical issues prevent merging: a logically impossible future customer date and an unintentional revert of a model mapping that was deliberately updated just days ago
  • bifrost/app/customers/case-studies/sunrun/metadata.json (fix date) and packages/cost/models/provider-helpers.ts (revert unrelated change)

Important Files Changed

File Analysis

Filename Score Overview
bifrost/app/customers/case-studies/sunrun/metadata.json 2/5 New case study metadata with invalid future customerSince date (2025-05-01)
packages/cost/models/provider-helpers.ts 0/5 Unrelated change that reverts kimi-k2 mapping from kimi-k2-0905 back to kimi-k2-0711

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Bifrost as Bifrost (Marketing)
    participant FileSystem as File System
    participant User as Website Visitor
    
    Dev->>FileSystem: Create metadata.json
    Dev->>FileSystem: Create src.mdx content
    Dev->>FileSystem: Add sunrun.webp logo
    Dev->>Bifrost: Update CaseStudies.tsx
    Note over Bifrost: Add "sunrun" to case studies array
    Dev->>FileSystem: Modify provider-helpers.ts
    Note over FileSystem: Unintended: revert kimi-k2 mapping
    
    User->>Bifrost: Visit /customers page
    Bifrost->>FileSystem: Load case studies metadata
    FileSystem-->>Bifrost: Return all case study data
    Bifrost->>Bifrost: Format customerSince dates
    Bifrost-->>User: Display case studies grid
    Note over User: Sees Sunrun with incorrect<br/>future customer date
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

"claude-3.5-sonnet-20240620": "claude-3.5-sonnet-v2",
"deepseek-r1": "deepseek-reasoner",
"kimi-k2": "kimi-k2-0905",
"kimi-k2": "kimi-k2-0711",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Unrelated change: reverts PR #5249 ("kimi-k2 go to latest") from Nov 14. This changes kimi-k2 mapping from kimi-k2-0905 back to kimi-k2-0711, which appears to be an accidental revert unrelated to the Sunrun case study.

Suggested change
"kimi-k2": "kimi-k2-0711",
"kimi-k2": "kimi-k2-0905",
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/cost/models/provider-helpers.ts
Line: 346:346

Comment:
**logic:** Unrelated change: reverts PR #5249 ("kimi-k2 go to latest") from Nov 14. This changes `kimi-k2` mapping from `kimi-k2-0905` back to `kimi-k2-0711`, which appears to be an accidental revert unrelated to the Sunrun case study.

```suggestion
  "kimi-k2": "kimi-k2-0905",
```

How can I resolve this? If you propose a fix, please make it concise.

@vercel vercel bot temporarily deployed to Preview – helicone-bifrost December 2, 2025 19:54 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants