Update RichInputConnection.java#2492
Conversation
Changed handling with cached text, for better working with apps like AFFiNE.
|
Hope it fix things like in these https://github.com/toeverything/AFFiNE/issues/13043 |
|
Can you give some information about what is working better, and how I can test it? Is it really better than the cache reload in all situations? I remember testing that took quite some time. |
Apologies for the broken link—simply copy and paste it, as usual. Unfortunately, I didn't have time for a full test (as I am currently away from home). It appears that the keyboard is losing its correct position and attempting to correct this using cached text. However, this results in some strange behavior... The error message in the log reads: "Cached text out of sync." |
|
Which apps and actions did you test? You write "In some editors, due to batch edit, we will receive stale information after having just performed an action (e.g. deleted text)" Your change breaks behavior when quickly deleting in both apps mentioned in the reload cache part (Joplin and com.farmerbb.notepad), which is not desirable.
Most likely this is because FUTO doesn't use composing text as far as I know. Many browsers and browser-based apps go against behavior that is documented with "Editor authors:" advice for whatever reason, which resulted in keyboards giving up use of this. |
|
Anyway, ideally the problemsm should be fixed in AFFiNE while leaving other apps in the mostly working state (there are still glitches in both apps I use for testing this). |
Changed handling with cached text, for better working with apps like AFFiNE.
Please make sure you are at least reasonably close to the contribution guidelines: https://github.com/HeliBorg/HeliBoard/blob/main/CONTRIBUTING.md#guidelines
Due to maintainer availability, your PR may take quite some time to be addressed