Add passive gesture data gathering#2397
Open
Helium314 wants to merge 133 commits into
Open
Conversation
usedWord <-> targetWord better detection when modifying comments
…ences people were writing in passive gathering
this avoids auto-scrolling to the top of the list every time selection changs (wtf?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@theeclecticdyslexic it's mostly working and done.
Passive gathering will be used whenever
isPassiveGatheringUsedreturns true, the same result also determines whether the indicator icon is shown. Indicator is a red icon at bottom left, which is a ring or a circle, depending on whether data is cached.Cache is written when closing the keyboard or switching input fields (and maybe on some more occasions).
Gathering is stopped and cache is cleared when entering incognito mode, or disabling passive gathering via the toolbar key. Toolbar key is available only after having passive gathering enabled at least once. Long-press disables gathering for 5 min.
There are settings to decide in which apps passive gathering is enabled, and which words are excluded.
The review screen allows filtering, sorting, selecting, deleting and sharing data.
What's missing / could use improvement:
PassiveGatheringSettings