Feat/946/default admin #964
Open
+180
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/api/entrypoint.sh
i added docstrings and removed a "hello worl" #946 https://github.com/orgs/Health-Informatics-UoN/projects/13?pane=issue&itemId=98223538&issue=Health-Informatics-UoN%7Ccarrot-mapper%7C946
|
4 tasks
Karthi-DStech
requested changes
Mar 7, 2025
app/shared/shared/mapping/management/commands/default_super_user.py
Outdated
Show resolved
Hide resolved
app/shared/shared/mapping/management/commands/default_super_user.py
Outdated
Show resolved
Hide resolved
AndrewThien
reviewed
Mar 8, 2025
app/shared/shared/mapping/management/commands/default_super_user.py
Outdated
Show resolved
Hide resolved
app/shared/shared/mapping/management/commands/default_super_user.py
Outdated
Show resolved
Hide resolved
app/shared/shared/mapping/management/commands/default_super_user.py
Outdated
Show resolved
Hide resolved
…er.py Co-authored-by: Tri Thien Nguyen <[email protected]>
…er.py Co-authored-by: Tri Thien Nguyen <[email protected]>
…er.py Co-authored-by: Tri Thien Nguyen <[email protected]>
adjusted the log messages for "add user" and "don't add user"
the "create default super user" test expectation needed to be updated to account for the new log message which includes the password
|
Thanks for your changes @g-pechorin. I can approve your PR once I get the request access. |
AndrewThien
reviewed
Mar 13, 2025
| # log the user's details | ||
| self.stdout.write( | ||
| self.style.SUCCESS( | ||
| f"Superuser successfully created with Username='{self.settings.SUPERUSER_DEFAULT_NAME}', Password='{self.settings.SUPERUSER_DEFAULT_PASSWORD}'" |
There was a problem hiding this comment.
Security concerns were raised by @brian-kim31 when password and username are exposed on the console.
Maybe you can hide the password somehow, only showing a few last letters for the purpose of tracking, for example?
There was a problem hiding this comment.
how about first-letter *** last-letter? so with Password123! it'd show P**********!?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Contents
Description
Adds a management command, is invoked on setup, which creates a default admin user for the carrot system iff there are 0 users in the database at present.
Related Issues or other material
closes #946
Screenshots, example outputs/behaviour etc.
✅ Added/updated tests?
This functionality relies on reading the django database, performing a single comparison - a test seems redundant.