-
Notifications
You must be signed in to change notification settings - Fork 43
Fix compression format: needs to have the zlib header around deflate. #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also add an example cli tool to make it easy to construct serialized histograms of various flavors. Seems like it might come in handy for someone beyond me.
Hmm, |
Also, for the command-line tool, it'd be nice to also have an argument to turn on auto-resize. |
Thanks for doing this so quickly! I just tried the branch version:
Result:
Thanks a lot! |
Ah, there's a build with no default features. I'll add @algermissen Glad it's working! Adding One other thing is that this is a backwards-incompatible change if people have caches of old histograms serialized with the plain deflate compression. If that is an issue for people we can resuscitate the old form to let them transcode the old form into the new form. |
tests/serialization.rs
Outdated
@@ -1,57 +1,61 @@ | |||
extern crate hdrsample; | |||
#[cfg(feature = "serialization")] | |||
#[cfg(test)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use all(feature = "serialization", test)
here I believe
Ah, yes, that came as a result of #56. For the example binary, we should use As for backwards compatibility, I think we should make the change, and then provide a fix for those in need if complaints should arise. |
Also, rename the example to `cli` and use a subcommand since I already have other ideas for things to add.
@marshallpierce if you think we might want to add other things, perhaps this should become a |
Not a bad idea, but I think I'd like to incubate things a bit as an example before we ship it as something semi-official. |
Note a slight backwards incompatibility for serialized histograms: #63 (comment)
Also add an example cli tool to make it easy to construct serialized
histograms of various flavors. Seems like it might come in handy for
someone beyond me.
Fixes #62.