Fix minor issues relating to #511 #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was named AllInstallData previously to avoid a conflict with another type, but that type is gone now (since HaxeFoundation#557).
The variable and function names were changed erroneously in HaxeFoundation#557 via find and replace.
This method, on the other hand, was missed out in HaxeFoundation#557
The function doesn't just get the library versions, but also the correctly capitalised library name.
We have to live with the current situation, and that means checking how the library should be capitalised
If we are installing a target library (e.g. hxcpp) it via git/hg, there is no need to check the server data. This avoids errors if we cannot connect to the server or if the server does not have the library.
So that we ignore --cpp if we find -lib hxcpp, regardless of how hxcpp is capitalised.
Simn
reviewed
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two main issues with installing from hxml (#511):
-lib HXCPPwill still prevent the duplicate install.