[hxb] Recover from BadModule failure #12395
Draft
+60
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently can happen when current display module (which will be invalidated in case of completion for example) is an indirect dependency of a module that ends up being loaded from init macros. Other cases should usually behave already from what I've seen. So here, when we're _not_ in full restore mode (display requests only, with some additional constraints), we're allowing hxb restoration of "BadModule" modules, avoiding a compiler failure. That "bad" module is then discarded, avoiding cache corruption (yes, this means it technically can happen more than once in a request, but that should be _very_ rare and not that much of an issue since no typing is involved). Ideally, this would trigger some specific warning.. but: - there isn't much the dev can do when seeing such warning? - warning support during display requests is pretty much non existent?
|
Can we use a variant type instead of a bool flag? I find these both more descriptive and easier to extend. |
Sure. Though at the moment I don't have much inspiration for the naming of the type + argument name 🤔 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently can happen when current display module (which will be invalidated in case of completion for example) is an indirect dependency of a module that ends up being loaded from init macros. Other cases should usually behave already from what I've seen.
So here, when we're not in full restore mode (display requests only, with some additional constraints), we're allowing hxb restoration of "BadModule" modules, avoiding a compiler failure. That "bad" module is then discarded, avoiding cache corruption (yes, this means it technically can happen more than once in a request, but that should be very rare and not that much of an issue since no typing is involved).
Ideally, this would trigger some specific warning(s).. (see TODOs in diff) but: