Skip to content

Improve zoomed debug hitboxes performance #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
+48 −1
Open

Improve zoomed debug hitboxes performance #3449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
991ad2c
Update FlxObject.hx
MaybeMaru Jul 12, 2025
2acef72
Small margin expansion
MaybeMaru Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 48 additions & 1 deletion flixel/FlxObject.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,6 +1255,53 @@ class FlxObject extends FlxBasic
return;

var rect = getBoundingBox(camera);
#if !flash
var viewLeft = camera.viewMarginLeft - 2;
var viewRight = camera.viewMarginRight + 2;
var viewTop = camera.viewMarginTop - 2;
var viewBottom = camera.viewMarginBottom + 2;

// clamp the rect to the bounds of the camera
// this is neccesary to avoid big bitmaps when zoomed in
if (rect.x < viewLeft)
{
rect.width -= (viewLeft - rect.x);
rect.x = viewLeft;
}
else if (rect.x > viewRight)
{
rect.x = viewRight;
rect.width = 0;
}

if (rect.right > viewRight)
{
rect.width = viewRight - rect.x;
}

if (rect.y < viewTop)
{
rect.height -= (viewTop - rect.y);
rect.y = viewTop;
}
else if (rect.y > viewBottom)
{
rect.y = viewBottom;
rect.height = 0;
}

if (rect.bottom > viewBottom)
{
rect.height = viewBottom - rect.y;
}

rect.width = Math.max(0, rect.width);
rect.height = Math.max(0, rect.height);

if (rect.isEmpty)
return;
#end

var gfx:Graphics = beginDrawDebug(camera);
drawDebugBoundingBox(gfx, rect, allowCollisions, immovable);
endDrawDebug(camera);
Expand Down Expand Up @@ -1285,7 +1332,7 @@ class FlxObject extends FlxBasic
function drawDebugBoundingBoxColor(gfx:Graphics, rect:FlxRect, color:FlxColor)
{
// fill static graphics object with square shape
gfx.lineStyle(1, color, 0.75);
gfx.lineStyle(1, color, 0.75, false, null, null, MITER, 255);
gfx.drawRect(rect.x + 0.5, rect.y + 0.5, rect.width - 1.0, rect.height - 1.0);
}

Expand Down