Remove unused legacy code & defines #3059

Starmapo · 2024-03-05T21:55:03Z

This PR removes a lot of code that goes unused in current versions of HaxeFlixel.

Removed the FLX_POST_PROCESS define & its related code. This was only available in versions of OpenFL before 4.0.0, which is not supported in the latest HaxeFlixel (minimum OpenFL version is 9.2.2).
Removed references to the openfl_next, lime_legacy & next defines. These defines were removed in the same commit as openfl_legacy, which was also already removed from HaxeFlixel in Removing all references of openfl_legacy. #2990.
Removed Lime & OpenFL version checks that are always true/false due to the current minimum versions (for example, #if (lime >= 7.0.0) is always true due to the minimum version being 8.0.2).

There are a few breaking changes:

The PostProcess class was deleted, which was still available when FLX_POST_PROCESS wasn't defined, though it was merely a placeholder. addPostProcess and removePostProcess were also removed from FlxG, having the same effect.
dump and undump have been removed from FlxGraphic, due to dump only doing anything when lime_legacy was defined. Due to this, all variables and functions that made use of these were removed, including FlxG.bitmap.onAssetsReload which refreshed the assets by calling undump whenever a change event was dispatched in openfl.utils.Assets. However, I could not find a single instance in Lime or OpenFL when this event would actually be dispatched, so it doesn't seem to have any purpose unless the user is meant to dispatch it themselves.

- Removed `FLX_POST_PROCESS` define & related code - Removed references to `openfl_next`, `lime_legacy` & `next` defines - Removed Lime & OpenFL version checks that are always true/false due to the current minimum versions

Geokureli · 2024-03-05T22:38:04Z

Because of the breaking changes, I've changed this PR so it will go to the 6.0.0 release branch rather than dev. @Starmapo please, backmerge the release6 branch into this branch, just in case

CI Errors:

TexturePackerAtlas Demo

source/MenuState.hx:128: characters 15-24 : flixel.system.frontEnds.BitmapFrontEnd has no field dumpCache

PostProcess Demo

source/PlayState.hx:6: characters 8-46 : Type not found : flixel.effects.postprocess.PostProcess
source/PlayState.hx:16: characters 28-39 : Type not found : PostProcess
source/PlayState.hx:16: characters 28-39 : ... For function argument 'child'
source/Main.hx:6: lines 6-13 : ... Defined in this class

Starmapo · 2024-03-05T23:50:04Z

Huh, I wasn't expecting there to be demos that use these features. TexturePackerAtlas was added 11 years ago, and PostProcess isn't even on the site currently. I'll make a PR over there fixing it.

Merged the release6 branch like you said 👍

Geokureli · 2024-03-06T03:40:14Z

@EliteMasterEric was requesting expansion of the FlxGraphic.dump feature, here: #3034

this PR seems to directly conflict with that

Starmapo · 2024-03-06T12:26:24Z

@EliteMasterEric was requesting expansion of the FlxGraphic.dump feature, here: #3034

this PR seems to directly conflict with that

I was originally going to make a PR for that, but then noticed that there were already FlxGraphic.dump and undump functions. There isn't a way to use them in the current version of HaxeFlixel due to the dumping functionality being enclosed in a lime_legacy define, so this PR removes them, and we'd just have to re-add the functions whenever we add the new dumping method.

If you do see a reason to keep them in this PR, then let me know.

flixel/FlxGame.hx

I mistakenly removed the entire code due to it including `lime_legacy`.

Geokureli · 2024-03-12T13:15:25Z

what is the plan, now?

Starmapo · 2024-03-12T13:42:06Z

We have to keep FlxG.bitmap.onAssetsReload which in turn means we have to keep the undump function which refreshes the bitmap data, regardless of if it was dumped before. However since dump is getting removed I asked you if it should be renamed to something more appropiate like refreshBitmap, or if the code should just be kept inside onAssetsReload.

Geokureli · 2024-03-12T15:17:46Z

I asked you if it should be renamed to something more appropriate like refreshBitmap, or if the code should just be kept inside onAssetsReload.

Sorry, I missed that, yeah I think thats a good idea

…Refreshed` respectively (old ones are now deprecated) - Also brought back `onAssetsReload()` & `getBitmapFromSystem()`

Starmapo · 2024-03-12T20:46:15Z

I decided to bring back undump() and canBeDumped renamed to refreshBitmap() and canBeRefreshed respectively, as well as the old ones but marked as deprecated, since it's possible that someone was using them for the refreshing function alone. Do let me know if you have any more suggestions.

Geokureli · 2025-01-29T19:22:17Z

Totally forgot about this, gonna look into it for the upcoming release. I backmerged release6, lmk if anything looks wrong

CI Failing is my fault, I'm on it

Starmapo · 2025-01-29T22:43:20Z

It should be good now, hoping CI can get worked out soon

… into remove-legacy-code

flixel/FlxGame.hx

flixel/graphics/FlxGraphic.hx

flixel/system/frontEnds/BitmapFrontEnd.hx

Geokureli · 2025-01-30T03:49:11Z

Thanks!

@from

* Fix FlxSpriteGroup origin (#2981) * update children origins relative to their positions * add originTransform unit test * Better framerate independant camera lerping (#2922) * adjust lerp based on the current frame rate * better framerate independant camera lerping * fix error * remove setter * docs * fix default lerp in follow() * fix typo * add #2981 and #2922 * Flxstate new (#2733) * take FlxState constructor instead of FlxState * add NextState type * 4.0.5 fixes * more 4.0.5 fixes * fix deprecation warnings in unit tests * take nextState in VCRFrontEnd * remove @from Instance in InitialState * use is operator * improve docs * rename method * more docs * more modular FlxSplash, set _gameJustStarted in FlxGame * allow splash to be skipped by a switchState call * touch-ups for #2733 (#3003) * take FlxState constructor instead of FlxState * add NextState type * 4.0.5 fixes * more 4.0.5 fixes * fix deprecation warnings in unit tests * take nextState in VCRFrontEnd * remove @from Instance in InitialState * use is operator * improve docs * rename method * more docs * more modular FlxSplash, set _gameJustStarted in FlxGame * allow splash to be skipped by a switchState call * touch-ups * add #2733 * Remove deprecated features (#3048) * remove deprecated features * more removals * Update FlxCamera.hx * remove defaultCameras * Default zoom (#2907) * add bindScrollPos * improve SCREEN_BY_SCREEN follow mode * make cameras suck less when using FlxCamera.defaultZoom <> 1.0 * Replace references to FlxG.camera with this.getDefaultCamera (#3072) * add getDefaultCamera, stop using FlxG.camera for everything * more uses of getDefaultCamera * fix flxpath * changelog * Calculate adjustedLerp only when necessary (#3106) * Calculate adjustedLerp only when necessary * Skip updateLerp on followLerp <= 0 * replace boundLerp with gt/lt checks --------- Co-authored-by: George Kurelic <[email protected]> * style * 1 line patch? (#3254) * update haxelib after merge * Log pos (#3338) * change logs to include posInfos * fix flash errors * D'oh * update Changelog * Add analog directional input to FlxVirtualPad (#3340) * add overloaded scale * add FlxReadOnlyPoint * deprecate statusAnimations * fix drawCircle centering * Add analog stick to FlxVirtualPad * fix code climate * D'oh * fix coverage * fix flash * add distance overloads * add FlxMath.getFrameLerp * honor camera in checkInput * add FlxVirtualStick deprecate FlxAnalog * rename to getElapsedLerp * fix multi-touch * D'oh! * doc * add FlxAnalogState helpers * rename signals, add statuses * add deadzone * remove lerp constructor arg * fix unit test warning * overload more shit * 5.10.0 * change 5.10->6 * Remove unused legacy code & defines (#3059) * Remove legacy code & defines - Removed `FLX_POST_PROCESS` define & related code - Removed references to `openfl_next`, `lime_legacy` & `next` defines - Removed Lime & OpenFL version checks that are always true/false due to the current minimum versions * Removed `legacy` define being set in include.xml * Re-added `#if !flash` check in `initRenderMethod` I mistakenly removed the entire code due to it including `lime_legacy`. * Brought back `undump()` & `canBeDumped` as `refreshBitmap()` & `canBeRefreshed` respectively (old ones are now deprecated) - Also brought back `onAssetsReload()` & `getBitmapFromSystem()` * Added missing line breaks * remove old import * Remove another deprecated define * Restored mistakenly-removed define check * Rename `refreshBitmap()` to `refresh()` --------- Co-authored-by: George FunBook <[email protected]> * FlxSave: Replace `FlxSaveStatus.ERROR` with SAVE_ERROR (#3294) * replace `FlxSaveStatus.ERROR` with SAVE_ERROR * update changelog * add link * Add deprecated ERROR back * remove implicit int casts to/from directions (#3308) * remove implicit int casts to/from directions * D'oh * D'oh! * deprecate operators and fix haxe 4.2.5 * order imports * remove casts, add explicit cast functions * fix not() and add tests * Doc * doc + tests * update changelog * finalize(?) changelog * enable glsl3 (when openfl does) (#3347) * update Changelog * prepare for release --------- Co-authored-by: 47rooks <[email protected]> Co-authored-by: rich <[email protected]> Co-authored-by: DetectiveBaldi <[email protected]> Co-authored-by: Flainn <[email protected]>

Starmapo added 2 commits March 5, 2024 17:22

Remove legacy code & defines

4636867

- Removed `FLX_POST_PROCESS` define & related code - Removed references to `openfl_next`, `lime_legacy` & `next` defines - Removed Lime & OpenFL version checks that are always true/false due to the current minimum versions

Removed legacy define being set in include.xml

7f42278

Geokureli changed the base branch from dev to release6 March 5, 2024 22:32

Geokureli added this to the 6.0.0 milestone Mar 5, 2024

Geokureli added Structure Breaking Change Code Style / Cleanup labels Mar 5, 2024

Merge remote-tracking branch 'origin/release6' into remove-legacy-code

08e809f

Starmapo mentioned this pull request Mar 6, 2024

Remove legacy code HaxeFlixel/flixel-demos#332

Merged

Geokureli added a commit to Geokureli/flixel that referenced this pull request Mar 6, 2024

deprecate dumping and post processing for HaxeFlixel#3059

1f1fb85

Geokureli reviewed Mar 6, 2024

View reviewed changes

flixel/FlxGame.hx Outdated Show resolved Hide resolved

Re-added #if !flash check in initRenderMethod

2ebe077

I mistakenly removed the entire code due to it including `lime_legacy`.

Starmapo added 2 commits March 12, 2024 16:41

Brought back undump() & canBeDumped as refreshBitmap() & `canBe…

18cf6d6

…Refreshed` respectively (old ones are now deprecated) - Also brought back `onAssetsReload()` & `getBitmapFromSystem()`

Added missing line breaks

d3846b1

charlesisfeline pushed a commit to VsFreyaDevs/flixel that referenced this pull request Aug 19, 2024

deprecate dumping and post processing for HaxeFlixel#3059

bcadbde

Merge branch 'release6' into remove-legacy-code

46a3813

Geokureli and others added 3 commits January 29, 2025 13:39

remove old import

289bcc1

Remove another deprecated define

df87c76

Restored mistakenly-removed define check

7b0f5ed

Merge branch 'release6' into remove-legacy-code

6186c69

Merge branch 'remove-legacy-code' of https://github.com/Starmapo/flixel…

47762ea

… into remove-legacy-code

Geokureli requested changes Jan 30, 2025

View reviewed changes

flixel/FlxGame.hx Show resolved Hide resolved

flixel/graphics/FlxGraphic.hx Outdated Show resolved Hide resolved

flixel/system/frontEnds/BitmapFrontEnd.hx Show resolved Hide resolved

Rename refreshBitmap() to refresh()

2df70d8

Geokureli approved these changes Jan 30, 2025

View reviewed changes

Geokureli merged commit 27a756b into HaxeFlixel:release6 Jan 30, 2025
10 checks passed

Geokureli mentioned this pull request Jan 30, 2025

Add FlxGraphic.dump #3345

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unused legacy code & defines #3059

Remove unused legacy code & defines #3059

Starmapo commented Mar 5, 2024

Geokureli commented Mar 5, 2024 •

edited

Loading

Starmapo commented Mar 5, 2024

Geokureli commented Mar 6, 2024

Starmapo commented Mar 6, 2024

Geokureli commented Mar 12, 2024

Starmapo commented Mar 12, 2024

Geokureli commented Mar 12, 2024

Starmapo commented Mar 12, 2024

Geokureli commented Jan 29, 2025 •

edited

Loading

Starmapo commented Jan 29, 2025

Geokureli commented Jan 30, 2025

Remove unused legacy code & defines #3059

Remove unused legacy code & defines #3059

Conversation

Starmapo commented Mar 5, 2024

Geokureli commented Mar 5, 2024 • edited Loading

Starmapo commented Mar 5, 2024

Geokureli commented Mar 6, 2024

Starmapo commented Mar 6, 2024

Geokureli commented Mar 12, 2024

Starmapo commented Mar 12, 2024

Geokureli commented Mar 12, 2024

Starmapo commented Mar 12, 2024

Geokureli commented Jan 29, 2025 • edited Loading

Starmapo commented Jan 29, 2025

Geokureli commented Jan 30, 2025

Geokureli commented Mar 5, 2024 •

edited

Loading

Geokureli commented Jan 29, 2025 •

edited

Loading