Skip to content

Handle KeyNotFoundException thrown from DictionaryPropertyProxy and DictionaryTypedPropertyProxy #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Havunen merged 4 commits into from
Jan 17, 2025
Merged

Handle KeyNotFoundException thrown from DictionaryPropertyProxy and DictionaryTypedPropertyProxy #40

Havunen merged 4 commits into from
Jan 17, 2025

Conversation

@sbiot-aveva
Copy link
Contributor

@sbiot-aveva sbiot-aveva commented Jan 13, 2025 •
edited
Loading

@sbiot-aveva sbiot-aveva marked this pull request as draft January 13, 2025 19:02
@sbiot-aveva sbiot-aveva marked this pull request as ready for review January 13, 2025 19:04
Havunen
Havunen reviewed Jan 13, 2025
View reviewed changes
Havunen
Havunen requested changes Jan 13, 2025
View reviewed changes
Copy link
Owner

@Havunen Havunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, otherwise LGTM

@sbiot-aveva sbiot-aveva requested a review from Havunen January 15, 2025 16:32
Havunen
Havunen reviewed Jan 16, 2025
View reviewed changes
Havunen
Havunen reviewed Jan 16, 2025
View reviewed changes
Havunen
Havunen reviewed Jan 16, 2025
View reviewed changes
@Havunen
Copy link
Owner

Havunen commented Jan 16, 2025

Lets keep the break in the error handling and use Contains to avoid try catch then this is good to be merged.

@sbiot-aveva sbiot-aveva requested a review from Havunen January 16, 2025 20:46
@Havunen Havunen merged commit ea4baf5 into Havunen:main Jan 17, 2025
3 checks passed
@Havunen
Copy link
Owner

Havunen commented Jan 17, 2025

Thank you for your contribution!

@Havunen
Copy link
Owner

Havunen commented Jan 17, 2025

This change is now available in version 4.2.0

@sbiot-aveva sbiot-aveva deleted the handle-keynotfoundexception branch January 17, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Havunen Havunen Awaiting requested review from Havunen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

KeyNotFoundException not handled by "logErrorAction"

2 participants

@sbiot-aveva @Havunen