-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix for ffmpegCommandRemoveStreamByProperty removes all streams #688
base: master
Are you sure you want to change the base?
Conversation
Thanks, haven't merged this as changing the variable to |
revert back to original naming convention per HGG fresh start on comparison logic, tested for corner cases with invalid inputs per HGG exclude stream 0 since this is the video stream, otherwise not_includes will remove it unless video codec specified change match to be exact to avoid issues such as eac3 getting removed for ac3 match change not_includes to compare against full array instead of individually to fix bug that caused everything to get removed if using multiple values
Updated to address issues, request review @HaveAGitGat |
sync to upstream master
Used UnknownWitcher's code from #576
I'm not much of a coder so i used a web ai to convert the code to typescript and then followed the standard plugin compiling rules. passed linting and tests. Have tested multi value includes and not includes myself and found it does fix the issue and no longer removes streams it shouldn't.
Should resolve #576 and resolve #562
Also added some tooltip info to instruct on proper handling of mp4 subs to close #682 and related. I think this is a more precise solution than running Tdarr_Plugin_MC93_Migz1Remux with force_conform option as the job log tooltip suggests.
example of log output from my testing on the same file with includes and not includes