Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feature-activation): update burying feature activations #69

Open
wants to merge 3 commits into
base: feat/feature-activation/transactions
Choose a base branch
from
Open

feat(feature-activation): update burying feature activations #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5262e37
feat(feature-activation): add transactions RFC
glevco Aug 9, 2023
f2615d1
update text to improve clarity
glevco Oct 25, 2023
864e46c
feat: update burying feature activations
glevco Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions projects/feature-activation/0001-feature-activation-for-blocks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,13 @@ With that being said, it is possible that a feature may or may not be activated
#### Burying feature activations
[Burying feature activations]: #burying-feature-activations

Burying a feature activation means changing code so "history is erased", and it's not clear that a feature was activated using the activation process.
Burying a feature activation means changing code so "history is erased", making it unclear that a feature was activated using the activation process.

It is allowed to change code that is conditional on feature activation, but **NOT** to remove a feature from the definition, as described in the [Feature and Criteria definition] section.
Considering the implementation of Feature Activation for Transactions, burying features is **NOT** allowed. This means that the code that performs a conditional check on feature activation cannot be removed. The reason for this is that feature activation for transactions depend on their timestamp, and it's not possible to differentiate between an old transaction that was just received now, or a new transaction that was created with an old timestamp. Read the Transactions RFC for more information.

We should also **NOT** remove a feature from the definition, as described in the [Feature and Criteria definition] section.

What _can_ be done is substituting the Feature Activation call for a constant, when a new checkpoint is created after a reasonable amount of blocks and time has passed since activation.

## Feature and Criteria definition
[Feature and Criteria definition]: #feature-and-criteria-definition
Expand Down
Loading