Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Visual regression tests #703

Closed
wants to merge 13 commits into from
Closed

Conversation

tuliomir
Copy link
Collaborator

@tuliomir tuliomir commented Dec 6, 2024

Acceptance Criteria

Notes

There are many frameworks that provide the visual regression functionalities. The chosen one was cypress-image-diff because:

  • It requires no third party account or integration: no strings attached
  • It's the simplest to set up: immediate return on effort

In a future moment we may decide that a full integration with a specialized third party is a better path and all we'll need to do to our code is to remove the cypress/visual-test folder, its configurations, and adapt the cy.compareSnapshot() command instances.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the tests label Dec 6, 2024
@tuliomir tuliomir self-assigned this Dec 6, 2024
@tuliomir tuliomir mentioned this pull request Feb 14, 2025
4 tasks
@tuliomir
Copy link
Collaborator Author

Superseded by #736

@tuliomir tuliomir closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant