Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the instructions to sign with Jsign #642

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the instructions to sign with Jsign #642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions ELECTRON.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,20 +58,16 @@ Then, just build it.

To sign using an EV Code Signing Certificate in a YubiKey, [follow this guide](https://www.electron.build/tutorials/code-signing-windows-apps-on-unix.html).

Use [JSign](https://ebourg.github.io/jsign/) to sign files; use osslsigncode to verify the signature.
Use [Jsign](https://ebourg.github.io/jsign/) to sign files; use osslsigncode to verify the signature.

On macOS, you should install the following: `brew install yubico-piv-tool osslsigncode1`.
On macOS, you should install the following: `brew install jsign yubico-piv-tool osslsigncode1`.

You can use the following commands to test whether it is working on your computer:

```bash

# First, sign the exe.
java \
--add-exports jdk.crypto.cryptoki/sun.security.pkcs11=ALL-UNNAMED \
--add-exports jdk.crypto.cryptoki/sun.security.pkcs11.wrapper=ALL-UNNAMED \
--add-opens java.base/java.security=ALL-UNNAMED \
-jar jsign-4.2.jar \
jsign \
--storetype YUBIKEY \
--certfile "$WIN_EV_CERTIFICATE_FILE" \
--storepass "$WIN_EV_TOKEN_PASSWORD" \
Expand Down