feat: call onNewNftEvent when a new NFT tx is received #150

andreabadesso · 2024-03-28T16:40:26Z

Motivation

This fixes #153

After the wallet-service refactor, we're no longer calling the old onNewTxRequest lambda (as what it used to do is now done by the daemon), so the logic that deals with NFTs should be called from the daemon.

This PR is not attempting to refactor the wallet-service and move all shared code to the common package, but to move only the minimum necessary code so that the nft util works both on the wallet-service and the daemon package.

Acceptance Criteria

We should move the nft utils from the wallet-service repository to the common package, that has methods common to both the lambdas and the daemon
We should move all transaction types to the common package
We should call use the nft util methods from the common package to call the onNewNftEvent lambda in the newVertexAccepted service of the daemon

Checklist

If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
Make sure either the unit tests and/or the QA tests are capable of testing the new features
Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

andreabadesso · 2024-03-31T23:02:05Z

package.json

  ],
  "engines": {
    "node": ">=18"
  },
  "nohoist": [
    "**"
  ],
-  "repository": "[email protected]:HathorNetwork/hathor-wallet-service-sync_daemon.git",
+  "repository": "[email protected]:HathorNetwork/hathor-wallet-service.git",


I renamed the repository

andreabadesso · 2024-03-31T23:26:00Z

packages/common/package.json

+    "@aws-sdk/client-lambda": "3.540.0",
+    "@hathor/wallet-lib": "0.39.0",
+    "winston": "^3.13.0"


These are defined as peerDependencies so they use the same version from the root package.json

andreabadesso · 2024-04-01T15:27:50Z

packages/daemon/src/types/event.ts

@@ -75,6 +75,7 @@ export type FullNodeEvent = {
      tokens: string[];
      token_name: null | string;
      token_symbol: null | string;
+      signal_bits: number;


We should open a PR to start storing this in the transactions table, but this is not yet coming from the event stream.

andreabadesso · 2024-04-01T18:06:01Z

packages/daemon/src/services/index.ts

    }

-    // TODO: Send message on SQS  for real-time update


We already did this in the past, it's on line 327

packages/common/__tests__/utils/nft.utils.test.ts

packages/common/package.json

tuliomir · 2024-04-02T21:30:12Z

packages/common/src/types.ts

We should have the Hathor header on this file.

Also, this is a types file that is half filled with utils functions. Maybe this is not the time to extract all those functions into separate dedicated files, but I believe at least an issue would be important to do so. In the future we may have circular dependencies because of these mixed responsibilities.

Adde the header in 61fe30e

I'm writing a project listing all refactors I think we need to do to share code between projects, I'll add this there

* tests: fixed nft tests on txProcessor * refactor: removed all methods related to the old wallet-service txProcessor

* feat: added nft utils * tests: added tests for common utils * chore: added common module to CI * refactor: moved used types to common package * tests: removed nft utils * tests: fixed nft tests on txProcessor * tests: mocking network on getconfig * tests: fixed nft tests on txProcessor * refactor: passing logger to invoke nft handler * refactor: no need to ignore ts * chore: removed jest script, instead using only test * chore: added hathor header * refactor: using common utils on txProcessor * tests: nft utils using old syntax * tests: skipped txProcessor tests * tests: fixed txProcessor tests * refactor: using isAuthority from common utils * refactor: using isAuthority from common types * refactor: using assertEnvVariablesExistance from common project * refactor: getting CREATE_NFT_MAX_RETRIES from env * docs: updated docstrings on nft utils * chore: removed events/nftCreationTx.ts * refactor: invalid import locations * refactor: remove unused lambdas (#155) * tests: fixed nft tests on txProcessor * refactor: removed all methods related to the old wallet-service txProcessor

* chore: added common package * chore: using wallet-lib from daemon resolution * chore: installed shared dependencies on root project, using peerDependencies * refactor: using addAlert method from common utils * chore: updated package.json with missing deps * refactor: using types from commons on wallet-service * chore: re-added sequelize to root * refactor: removed isNftAutoReviewEnabled from services * tests: mocked assertEnv * tests: mocked assertEnv on integration tests * chore: removed nft utils * refactor: removed old addAlerts from the wallet-service package * chore: wallet-lib is now a peerDependency in wallet-service package * refactor: logger is now a required param in addAlert, refactored all methods in wallet-service package * docs: added missing hathor header * refactor: invalid type for metadata on addAlert * tests: passing mocked logger * chore: updated gitignore to ignore env files * chore: revert eslint package updates * refactor: using types from commons on wallet-service * refactor: removed unused commented line * chore: missing package in daemon * refactor: using transaction type from common * refactor: bitcoinjs is not a shared dep * chore: added a comment explaining that logger is a param temporarily * refactor: removed default from metadata * chore: lint fixes and package ordering * feat: call onNewNftEvent when a new NFT tx is received (#150) * feat: added nft utils * tests: added tests for common utils * chore: added common module to CI * refactor: moved used types to common package * tests: removed nft utils * tests: fixed nft tests on txProcessor * tests: mocking network on getconfig * tests: fixed nft tests on txProcessor * refactor: passing logger to invoke nft handler * refactor: no need to ignore ts * chore: removed jest script, instead using only test * chore: added hathor header * refactor: using common utils on txProcessor * tests: nft utils using old syntax * tests: skipped txProcessor tests * tests: fixed txProcessor tests * refactor: using isAuthority from common utils * refactor: using isAuthority from common types * refactor: using assertEnvVariablesExistance from common project * refactor: getting CREATE_NFT_MAX_RETRIES from env * docs: updated docstrings on nft utils * chore: removed events/nftCreationTx.ts * refactor: invalid import locations * refactor: remove unused lambdas (#155) * tests: fixed nft tests on txProcessor * refactor: removed all methods related to the old wallet-service txProcessor * tests: fixed failing test * fix: serverless failing (#162) * refactor: logger is now a required param in addAlert, refactored all methods in wallet-service package * chore: changed module resolution and several package locks * chore: added common library to externals whitelist and whitelisted it in tsloader * chore: wallet-service common package moved from direct path to workspace * chore: added common as a peer dependency and restored peer dependencies * chore: removed peer dependencies as they were not working with serverless-monorepo * chore: added comment on hoisting limits * chore: added comment explaining externals in webpack

andreabadesso self-assigned this Mar 28, 2024

andreabadesso added the enhancement New feature or request label Mar 28, 2024

andreabadesso force-pushed the feat/send-nft branch from 36d3378 to d73011e Compare March 31, 2024 23:01

andreabadesso commented Mar 31, 2024

View reviewed changes

andreabadesso force-pushed the feat/send-nft branch 2 times, most recently from b75dff9 to 438e9c9 Compare April 1, 2024 00:05

andreabadesso changed the base branch from master to refactor/common-project April 1, 2024 00:05

andreabadesso commented Apr 1, 2024

View reviewed changes

andreabadesso force-pushed the feat/send-nft branch 4 times, most recently from a6ee5ce to 10a9f49 Compare April 1, 2024 17:52

andreabadesso commented Apr 1, 2024

View reviewed changes

andreabadesso force-pushed the feat/send-nft branch 2 times, most recently from cf8b820 to 0ebc4d8 Compare April 1, 2024 18:19

andreabadesso changed the title ~~feat: send nft metadata~~ feat: call onNewNftEvent when a new NFT tx is received Apr 1, 2024

tuliomir reviewed Apr 2, 2024

View reviewed changes

andreabadesso force-pushed the refactor/common-project branch 3 times, most recently from deb36e6 to 8da7285 Compare April 3, 2024 15:22

andreabadesso force-pushed the feat/send-nft branch 2 times, most recently from 1f867a2 to cdf68cc Compare April 3, 2024 16:12

andreabadesso requested review from pedroferreira1 and tuliomir April 3, 2024 16:23

andreabadesso force-pushed the refactor/common-project branch from fe72085 to e4200a0 Compare April 5, 2024 15:25

andreabadesso force-pushed the feat/send-nft branch 2 times, most recently from b8783e9 to dfb1b61 Compare April 5, 2024 16:26

tuliomir approved these changes Apr 5, 2024

View reviewed changes

andreabadesso force-pushed the feat/send-nft branch from 73e4c9f to cd595af Compare April 8, 2024 18:56

andreabadesso added 18 commits April 19, 2024 15:35

tests: removed nft utils

3c3ae68

tests: fixed nft tests on txProcessor

0a8674e

tests: mocking network on getconfig

84ff587

tests: fixed nft tests on txProcessor

3548e14

refactor: passing logger to invoke nft handler

d37c830

refactor: no need to ignore ts

7819c0a

chore: removed jest script, instead using only test

cc28a45

chore: added hathor header

83eae6e

refactor: using common utils on txProcessor

77f7540

tests: nft utils using old syntax

11eb9e8

tests: skipped txProcessor tests

92d4013

tests: fixed txProcessor tests

13915fb

refactor: using isAuthority from common utils

bb2e878

refactor: using isAuthority from common types

3c8a52e

refactor: using assertEnvVariablesExistance from common project

4a380e9

refactor: getting CREATE_NFT_MAX_RETRIES from env

b83f0cb

docs: updated docstrings on nft utils

da0d95c

chore: removed events/nftCreationTx.ts

a702252

andreabadesso force-pushed the feat/send-nft branch 2 times, most recently from c3c1ca1 to 0de6578 Compare April 19, 2024 19:45

refactor: invalid import locations

a951693

andreabadesso force-pushed the feat/send-nft branch from 0de6578 to a951693 Compare April 19, 2024 20:46

refactor: remove unused lambdas (#155)

b6788ad

* tests: fixed nft tests on txProcessor * refactor: removed all methods related to the old wallet-service txProcessor

andreabadesso merged commit c19c2c3 into refactor/common-project Apr 19, 2024
1 check passed

andreabadesso deleted the feat/send-nft branch April 19, 2024 22:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: call onNewNftEvent when a new NFT tx is received #150

feat: call onNewNftEvent when a new NFT tx is received #150

andreabadesso commented Mar 28, 2024 •

edited

Loading

andreabadesso Mar 31, 2024

andreabadesso Mar 31, 2024

andreabadesso Apr 1, 2024

andreabadesso Apr 1, 2024

tuliomir Apr 2, 2024

andreabadesso Apr 3, 2024

feat: call onNewNftEvent when a new NFT tx is received #150

feat: call onNewNftEvent when a new NFT tx is received #150

Conversation

andreabadesso commented Mar 28, 2024 • edited Loading

Motivation

Acceptance Criteria

Checklist

andreabadesso Mar 31, 2024

Choose a reason for hiding this comment

andreabadesso Mar 31, 2024

Choose a reason for hiding this comment

andreabadesso Apr 1, 2024

Choose a reason for hiding this comment

andreabadesso Apr 1, 2024

Choose a reason for hiding this comment

tuliomir Apr 2, 2024

Choose a reason for hiding this comment

andreabadesso Apr 3, 2024

Choose a reason for hiding this comment

andreabadesso commented Mar 28, 2024 •

edited

Loading