Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increased loadTokensAsync to 5 minutes (up from 6s) #319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreabadesso
Copy link
Collaborator

Acceptance Criteria

  • loadTokensAsync should not timeout on larger wallets during the load process

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso force-pushed the chore/async-load-tokens-5min branch from ab4ecbf to 84543e9 Compare December 2, 2022 14:36
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #319 (4dd6fb5) into dev (1c7a93a) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 4dd6fb5 differs from pull request most recent head 31a9e1e. Consider uploading reports for the commit 31a9e1e to get more accurate results

@@            Coverage Diff             @@
##              dev     #319      +/-   ##
==========================================
- Coverage   94.51%   94.49%   -0.03%     
==========================================
  Files          36       34       -2     
  Lines        2244     2054     -190     
  Branches      260      238      -22     
==========================================
- Hits         2121     1941     -180     
+ Misses        123      113      -10     
Impacted Files Coverage Δ
src/commons.ts 83.24% <0.00%> (-1.48%) ⬇️
src/db/index.ts 99.28% <0.00%> (-0.03%) ⬇️
src/api/wallet.ts 97.77% <0.00%> (-0.02%) ⬇️
src/types.ts 98.59% <0.00%> (ø)
src/utils/pushnotification.utils.ts 100.00% <0.00%> (ø)
tests/utils/firebase-admin.mock.ts
src/api/txPushNotificationRequested.ts
src/db/utils.ts 100.00% <0.00%> (+2.12%) ⬆️
src/txProcessor.ts 74.60% <0.00%> (+2.63%) ⬆️
src/api/pushRegister.ts 100.00% <0.00%> (+3.70%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andreabadesso andreabadesso force-pushed the chore/async-load-tokens-5min branch from 84543e9 to 31a9e1e Compare January 3, 2023 10:43
@luislhl luislhl changed the base branch from dev to master April 21, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants